From: Cory Maccarrone <darkstar6262@gmail.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
Marek Belisko <marek.belisko@open-nandra.com>
Subject: Re: [PATCH v4] mmc-omap: Add support for 16-bit and 32-bit registers
Date: Mon, 23 Nov 2009 10:35:51 -0800 [thread overview]
Message-ID: <6cb013310911231035p2f701b10u2d16c6b39d560353@mail.gmail.com> (raw)
In-Reply-To: <20091123191224.GA2076@localhost.localdomain>
On Mon, Nov 23, 2009 at 11:12 AM, Ladislav Michl
<Ladislav.Michl@seznam.cz> wrote:
> Ah, there is no valid reason to make it bitfield, right? Whole struct is
> not well layed wtr alignment, but please do not make it any worse. That is
> my last complain, I swear ;-). Thank you for your patience.
>
> Other than that, tested on OMAP5910 and it works now (though it needs
> additional patch, see here:
> http://thread.gmane.org/gmane.linux.kernel.mmc/649).
>
> Tested-by: Ladislav Michl <ladis@linux-mips.org>
Heh, fair enough :) Thanks for your patience too -- I'll convert it
to an unsigned int and resubmit. Hopefully 5th time's the charm. :)
Glad to hear it's working with that patch too, that adds some
confidence to my changes.
Thanks
- Cory
prev parent reply other threads:[~2009-11-23 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 16:23 [PATCH v4] mmc-omap: Add support for 16-bit and 32-bit registers Cory Maccarrone
2009-11-23 17:18 ` Tony Lindgren
2009-11-23 19:12 ` Ladislav Michl
2009-11-23 18:35 ` Cory Maccarrone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cb013310911231035p2f701b10u2d16c6b39d560353@mail.gmail.com \
--to=darkstar6262@gmail.com \
--cc=ladis@linux-mips.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marek.belisko@open-nandra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.