Re: [PATCH v2] media: v4l2-async: Improve v4l2_async_notifier_add_*_subdev() API

From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-media@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Ezequiel Garcia <ezequiel@collabora.com>
Subject: Re: [PATCH v2] media: v4l2-async: Improve v4l2_async_notifier_add_*_subdev() API
Date: Thu, 21 Jan 2021 08:36:37 +0200	[thread overview]
Message-ID: <6cb2906c-299b-3dd2-6be4-8874dcb41284@ideasonboard.com> (raw)
In-Reply-To: <20210117063304.1650-1-laurent.pinchart+renesas@ideasonboard.com>

Hi,

On 17/01/2021 08:33, Laurent Pinchart wrote:
> The functions that add an async subdev to an async subdev notifier take
> as an argument the size of the container structure they need to
> allocate. This is error prone, as passing an invalid size will not be
> caught by the compiler. Wrap those functions in macros that take a
> container type instead of a size, and cast the returned pointer to the
> desired type. The compiler will catch mistakes if the incorrect type is
> passed to the macro, as the assignment types won't match.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> Changes since v1:
> 
> - Fix variable name and type in renesas_ceu and ti-cal

For the core change and ti-cal:

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

 Tomi