Re: [PATCH v3 2/4] iio: trigger: move to the cleanup.h magic

From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Nuno Sa <nuno.sa@analog.com>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	 Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v3 2/4] iio: trigger: move to the cleanup.h magic
Date: Mon, 18 Mar 2024 10:22:17 +0100	[thread overview]
Message-ID: <6d6697113e4b71d85f17c570167925c4c11de52c.camel@gmail.com> (raw)
In-Reply-To: <ZfX1Yv456gRr0RU4@surfacebook.localdomain>

On Sat, 2024-03-16 at 21:39 +0200, Andy Shevchenko wrote:
> Thu, Feb 29, 2024 at 04:10:26PM +0100, Nuno Sa kirjoitti:
> > Use the new cleanup magic for handling mutexes in IIO. This allows us to
> > greatly simplify some code paths.
> 
> ...
> 
> >  static void iio_trigger_put_irq(struct iio_trigger *trig, int irq)
> >  {
> > -	mutex_lock(&trig->pool_lock);
> > +	guard(mutex)(&trig->pool_lock);
> >  	clear_bit(irq - trig->subirq_base, trig->pool);
> 
> Another side note: Why do we need atomic bit operation(s)?
> 

Did not checked the code but my guess is that the lock is always grabbed so we
likely don't need the atomic variants. But that's something for a future patch.

- Nuno Sá