From: "Juha-Pekka Heikkilä" <juhapekka.heikkila@gmail.com>
To: Swati Sharma <swati2.sharma@intel.com>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 2/4] drm/i915/icl: Add Y210, Y212, Y216 plane control definitions
Date: Tue, 27 Nov 2018 22:54:28 +0200 [thread overview]
Message-ID: <6dcf5ee6-3cbe-fd5b-f0d4-7bffd1ff2aba@gmail.com> (raw)
In-Reply-To: <1540186308-4390-3-git-send-email-swati2.sharma@intel.com>
I did earlier give R-b for this patch. The patch anyway hasn't changed
as those defines have not changed.
/Juha-Pekka
Swati Sharma kirjoitti 22.10.2018 klo 8.31:
> From: Vidya Srinivas <vidya.srinivas@intel.com>
>
> Added needed plane control flag definitions for Y210, Y212 and
> Y216 formats.
>
> v3: no change
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index a71c507..cbb2917 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -6506,6 +6506,9 @@ enum {
> #define PLANE_CTL_FORMAT_RGB_565 (14 << 24)
> #define ICL_PLANE_CTL_FORMAT_MASK (0x1f << 23)
> #define PLANE_CTL_PIPE_CSC_ENABLE (1 << 23) /* Pre-GLK */
> +#define PLANE_CTL_FORMAT_Y210 (1 << 23)
> +#define PLANE_CTL_FORMAT_Y212 (3 << 23)
> +#define PLANE_CTL_FORMAT_Y216 (5 << 23)
> #define PLANE_CTL_KEY_ENABLE_MASK (0x3 << 21)
> #define PLANE_CTL_KEY_ENABLE_SOURCE (1 << 21)
> #define PLANE_CTL_KEY_ENABLE_DESTINATION (2 << 21)
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-27 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 5:31 [PATCH v3 0/4] Enable Y210, Y212, Y216 formats for ICL Swati Sharma
2018-10-22 5:31 ` [PATCH v3 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc Swati Sharma
2018-10-22 5:31 ` [PATCH v3 2/4] drm/i915/icl: Add Y210, Y212, Y216 plane control definitions Swati Sharma
2018-11-27 20:54 ` Juha-Pekka Heikkilä [this message]
2018-10-22 5:31 ` [PATCH v3 3/4] drm/i915/icl: Preparations for enabling Y210, Y212, Y216 formats Swati Sharma
2018-10-22 5:31 ` [PATCH v3 4/4] drm/i915/icl: Enable Y210, Y212, Y216 format for primary and sprite planes Swati Sharma
2018-11-27 21:10 ` Juha-Pekka Heikkilä
2018-10-22 15:23 ` ✗ Fi.CI.BAT: failure for Enable Y210, Y212, Y216 formats for ICL (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dcf5ee6-3cbe-fd5b-f0d4-7bffd1ff2aba@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.