From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 1/3] xen/privcmd: replace kcalloc() by kvcalloc() when allocating empty pages
Date: Thu, 23 Sep 2021 14:30:43 +0200 [thread overview]
Message-ID: <6e90efe0-4c0d-55d9-bff8-6da9b9614cd1@suse.com> (raw)
In-Reply-To: <6d698901-98a4-05be-c421-bcd0713f5335@suse.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1209 bytes --]
On 22.09.21 12:16, Jan Beulich wrote:
> Osstest has been suffering test failures for a little while from order-4
> allocation failures, resulting from alloc_empty_pages() calling
> kcalloc(). As there's no need for physically contiguous space here,
> switch to kvcalloc().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
> ---
> RFC: I cannot really test this, as alloc_empty_pages() only gets used in
> the auto-translated case (i.e. on Arm or PVH Dom0, the latter of
> which I'm not trusting enough yet to actually start playing with
> guests).
>
> There are quite a few more kcalloc() where it's not immediately clear
> how large the element counts could possibly grow nor whether it would be
> fine to replace them (i.e. physically contiguous space not required).
I don't think those are an issue. Per default the sizes seem to be well
below a single page.
> I wasn't sure whether to Cc stable@ here; the issue certainly has been
> present for quite some time. But it didn't look to cause issues until
> recently.
I'd rather add it to stable. Its not as if the patch had a high
complexity.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-09-23 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 10:14 [PATCH 0/3] xen/privcmd: misc corrections Jan Beulich
2021-09-22 10:16 ` [PATCH RFC 1/3] xen/privcmd: replace kcalloc() by kvcalloc() when allocating empty pages Jan Beulich
2021-09-23 12:30 ` Juergen Gross [this message]
2021-09-22 10:17 ` [PATCH 2/3] xen/privcmd: fix error handling in mmap-resource processing Jan Beulich
2021-09-22 13:29 ` Boris Ostrovsky
2021-09-22 13:39 ` Jan Beulich
2021-09-22 13:56 ` Boris Ostrovsky
2021-09-22 10:18 ` [PATCH 3/3] xen/privcmd: drop "pages" parameter from xen_remap_pfn() Jan Beulich
2021-09-22 14:02 ` Boris Ostrovsky
2021-10-05 6:39 ` [PATCH 0/3] xen/privcmd: misc corrections Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e90efe0-4c0d-55d9-bff8-6da9b9614cd1@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.