From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2 1/7] x86/EFI: sanitize build logic
Date: Mon, 10 Aug 2020 15:38:26 +0100 [thread overview]
Message-ID: <6eab1af6-1845-c4b6-5fbb-76d9974404f1@citrix.com> (raw)
In-Reply-To: <0a544a9d-edc8-cb71-05a2-77c860050836@citrix.com>
On 07/08/2020 17:33, Andrew Cooper wrote:
> On 07/08/2020 12:32, Jan Beulich wrote:
>> With changes done over time and as far as linking goes, the only special
>> thing about building with EFI support enabled is the need for the dummy
>> relocations object for xen.gz uniformly in all build stages. All other
>> efi/*.o can be consumed from the built_in*.o files.
>>
>> In efi/Makefile, besides moving relocs-dummy.o to "extra", also properly
>> split between obj-y and obj-bin-y.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> I'd prefer to see this all in Kconfig, but this is a clear improvement
> in its own right.
Actually, it breaks the build with LIVEPATCH enabled.
make[2]: *** No rule to make target 'efi/buildid.o', needed by
'/local/security/xen.git/xen/xen.efi'. Stop.
make[2]: *** Waiting for unfinished jobs....
Makefile:355: recipe for target '/local/security/xen.git/xen/xen' failed
next prev parent reply other threads:[~2020-08-10 14:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 11:30 [PATCH v2 0/7] x86: build adjustments Jan Beulich
2020-08-07 11:32 ` [PATCH v2 1/7] x86/EFI: sanitize build logic Jan Beulich
2020-08-07 16:33 ` Andrew Cooper
2020-08-10 14:38 ` Andrew Cooper [this message]
2020-08-17 15:20 ` Jan Beulich
2020-08-07 11:32 ` [PATCH v2 2/7] x86: don't build with EFI support in shim-exclusive mode Jan Beulich
2020-08-18 13:00 ` Roger Pau Monné
2020-08-19 7:33 ` Jan Beulich
2020-08-19 7:59 ` Roger Pau Monné
2020-08-07 11:33 ` [PATCH v2 3/7] x86: shrink struct arch_{vcpu,domain} when !HVM Jan Beulich
2020-08-07 17:14 ` Andrew Cooper
2020-08-19 8:35 ` Jan Beulich
2020-08-07 11:33 ` [PATCH v2 4/7] bitmap: move to/from xenctl_bitmap conversion helpers Jan Beulich
2020-08-07 17:50 ` Andrew Cooper
2020-08-19 8:45 ` Jan Beulich
2020-08-10 15:44 ` Julien Grall
2020-08-07 11:34 ` [PATCH v2 5/7] x86: move domain_cpu_policy_changed() Jan Beulich
2020-08-07 17:53 ` Andrew Cooper
2020-08-07 11:34 ` [PATCH v2 6/7] x86: move cpu_{up,down}_helper() Jan Beulich
2020-08-07 17:55 ` Andrew Cooper
2020-08-07 11:35 ` [PATCH v2 7/7] x86: don't include domctl and alike in shim-exclusive builds Jan Beulich
2020-08-18 13:08 ` Roger Pau Monné
2020-08-19 7:37 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eab1af6-1845-c4b6-5fbb-76d9974404f1@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.