From: Ben Cheatham <benjamin.cheatham@amd.com>
To: dan.j.williams@intel.com, jonathan.cameron@huawei.com,
rafael@kernel.org, james.morse@arm.com, tony.luck@intel.com,
bp@alien8.de
Cc: dave@stogolabs.net, dave.jiang@intel.com,
alison.schofield@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, linux-cxl@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v15 2/4] EINJ: Add CXL error type support
Date: Tue, 12 Mar 2024 10:33:03 -0500 [thread overview]
Message-ID: <6f4d6962-3093-4f21-93b8-f2fa2bb2b465@amd.com> (raw)
In-Reply-To: <20240311142508.31717-3-Benjamin.Cheatham@amd.com>
The kernel build bot found a build error with the following config:
CONFIG_PCI=n
CONFIG_CXL_BUS=n
CONFIG_ACPI_APEI_EINJ=y
CONFIG_ACPI_APEI_EINJ_CXL=y
The following diff seems to fix the issue:
diff --git a/drivers/acpi/apei/Kconfig b/drivers/acpi/apei/Kconfig
index f01afa2805be..7d5634357d4c 100644
--- a/drivers/acpi/apei/Kconfig
+++ b/drivers/acpi/apei/Kconfig
@@ -63,6 +63,7 @@ config ACPI_APEI_EINJ
config ACPI_APEI_EINJ_CXL
bool "CXL Error INJection Support"
default ACPI_APEI_EINJ
+ depends on PCI
depends on ACPI_APEI_EINJ && CXL_BUS <= ACPI_APEI_EINJ
help
Support for CXL protocol Error INJection through debugfs/cxl.
Or if depending on CONFIG_CXL_BUS is preferable (it also depends on CONFIG_PCI):
diff --git a/drivers/acpi/apei/Kconfig b/drivers/acpi/apei/Kconfig
index f01afa2805be..3cfe7e7475f2 100644
--- a/drivers/acpi/apei/Kconfig
+++ b/drivers/acpi/apei/Kconfig
@@ -63,7 +63,8 @@ config ACPI_APEI_EINJ
config ACPI_APEI_EINJ_CXL
bool "CXL Error INJection Support"
default ACPI_APEI_EINJ
- depends on ACPI_APEI_EINJ && CXL_BUS <= ACPI_APEI_EINJ
+ depends on ACPI_APEI_EINJ
+ depends on CXL_BUS && CXL_BUS <= ACPI_APEI_EINJ
help
Support for CXL protocol Error INJection through debugfs/cxl.
Availability and which errors are supported is dependent on
I could send out yet another version, but since this is a one line change I would appreciate
it if whoever picks these patches up would just include this fix.
Thanks,
Ben
next prev parent reply other threads:[~2024-03-12 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 14:25 [PATCH v15 0/4] cxl, EINJ: Update EINJ for CXL error types Ben Cheatham
2024-03-11 14:25 ` [PATCH v15 1/4] EINJ: Migrate to a platform driver Ben Cheatham
2024-03-11 14:25 ` [PATCH v15 2/4] EINJ: Add CXL error type support Ben Cheatham
2024-03-12 14:16 ` kernel test robot
2024-03-12 15:33 ` Ben Cheatham [this message]
2024-03-13 5:47 ` Dan Williams
2024-03-13 5:54 ` Dan Williams
2024-03-13 13:24 ` Ben Cheatham
2024-03-13 5:58 ` Dan Williams
2024-03-13 13:24 ` Ben Cheatham
2024-03-11 14:25 ` [PATCH v15 3/4] cxl/core: Add CXL EINJ debugfs files Ben Cheatham
2024-03-13 6:00 ` Dan Williams
2024-03-13 13:24 ` Ben Cheatham
2024-03-11 14:25 ` [PATCH v15 4/4] EINJ, Documentation: Update EINJ kernel doc Ben Cheatham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f4d6962-3093-4f21-93b8-f2fa2bb2b465@amd.com \
--to=benjamin.cheatham@amd.com \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stogolabs.net \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.