Re: [PATCH] Support for 3M multitouch panel

From: "Stéphane Chatty" <chatty@enac.fr>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Stephane Chatty <chatty@lii-enac.fr>,
	dmitry.torokhov@gmail.com, ynezz@true.cz,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] Support for 3M multitouch panel
Date: Wed, 23 Dec 2009 10:47:58 +0100	[thread overview]
Message-ID: <710D1CE6-4FB1-490F-9452-0ADEE565CC22@enac.fr> (raw)
In-Reply-To: <alpine.LNX.2.00.0912230131530.3755@pobox.suse.cz>

Le 23 déc. 09 à 01:33, Jiri Kosina a écrit :

> On Tue, 22 Dec 2009, Stephane Chatty wrote:
>
>> Added support for 3M multitouch panels.
>
> ... I had to fix trivial build failure (3M vs. MMM inconsistency in
> defines).

Oops, sorry. This 3M / MMM thing has bothered me until the end, and I  
probably did one change too much.

>
>> +config HID_3M_PCT
>> +	tristate "3M PCT" if EMBEDDED
>> +	depends on USB_HID
>> +	default !EMBEDDED
>
> Hmm, I wouldn't be so sure about this in this case ... the point  
> behind
> 'default !EMBEDDED' was that simple a straightforward quirks for HID
> devices (which are implemented as drivers on HID bus) wouldn't have  
> to be
> enabled separately, if the device is otherwise more-or-less HID  
> standard
> compliant.
>
> But this driver is rather standalone driver, I guess we'd want to  
> have it
> normally selectable.

I guess too. I had just copied other sections, not fully  
understanding what I was doing.

St.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html