Re: [PATCH V2] PCI: rcar: Clean up the macros

From: Marek Vasut <marek.vasut@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-pci@vger.kernel.org
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH V2] PCI: rcar: Clean up the macros
Date: Sun, 8 Apr 2018 18:34:39 +0200	[thread overview]
Message-ID: <710bfa56-09a6-5017-e493-fce7cd09e788@gmail.com> (raw)
In-Reply-To: <7f63726a-fb96-a329-cce4-d1dd64b33de7@infradead.org>

On 04/08/2018 05:27 PM, Randy Dunlap wrote:
> On 04/08/2018 06:09 AM, Marek Vasut wrote:
>> This patch replaces the (1 << n) with BIT(n) and cleans up whitespace,
>> no functional change.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>> Cc: Phil Edworthy <phil.edworthy@renesas.com>
>> Cc: Simon Horman <horms+renesas@verge.net.au>
>> Cc: Wolfram Sang <wsa@the-dreams.de>
>> Cc: linux-renesas-soc@vger.kernel.org
>> ---
>> V2: Reword the commit message
>> ---
>>  drivers/pci/host/pcie-rcar.c | 52 ++++++++++++++++++++++----------------------
>>  1 file changed, 26 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
>> index 25f68305322c..5ab7bf6a8de0 100644
>> --- a/drivers/pci/host/pcie-rcar.c
>> +++ b/drivers/pci/host/pcie-rcar.c
>> @@ -30,9 +30,9 @@
> 
> missing this:
> 
> #include <linux/bitops.h>

This compiles just fine without it though, which means it's probably
pulled in through some of the other includes already present.

-- 
Best regards,
Marek Vasut