From: Ralph Campbell <rcampbell@nvidia.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>,
<akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>
Cc: Zi Yan <ziy@nvidia.com>, Yang Shi <yang.shi@linux.alibaba.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCHv2 1/8] khugepaged: Add self test
Date: Mon, 6 Apr 2020 11:53:56 -0700 [thread overview]
Message-ID: <71529d58-e51d-4f36-037d-42e60dd5a8ff@nvidia.com> (raw)
In-Reply-To: <20200403112928.19742-2-kirill.shutemov@linux.intel.com>
On 4/3/20 4:29 AM, Kirill A. Shutemov wrote:
> The test checks if khugepaged is able to recover huge page where we
> expetect to do so. It only covers anon-THP for now.
>
> Currenlty the test shows few failures. They are going to be addressed by
> the following patches.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
One minor nit below but otherwise looks OK.
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
> +
> +static void collapse_signle_pte_entry(void)
> +{
Shouldn't this be collapse_single_pte_entry()?
(and change the places where it is called)
next prev parent reply other threads:[~2020-04-06 18:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 11:29 [PATCHv2 0/8] thp/khugepaged improvements and CoW semantics Kirill A. Shutemov
2020-04-03 11:29 ` [PATCHv2 1/8] khugepaged: Add self test Kirill A. Shutemov
2020-04-06 14:59 ` Zi Yan
2020-04-06 15:20 ` Kirill A. Shutemov
2020-04-06 18:50 ` Zi Yan
2020-04-08 14:21 ` Kirill A. Shutemov
2020-04-08 15:53 ` Zi Yan
2020-04-10 11:47 ` Kirill A. Shutemov
2020-04-10 14:36 ` Zi Yan
2020-04-10 14:58 ` Kirill A. Shutemov
2020-04-10 15:03 ` Zi Yan
2020-04-06 18:53 ` Ralph Campbell [this message]
2020-04-03 11:29 ` [PATCHv2 2/8] khugepaged: Do not stop collapse if less than half PTEs are referenced Kirill A. Shutemov
2020-04-06 18:13 ` Yang Shi
2020-04-06 19:53 ` Ralph Campbell
2020-04-09 13:34 ` Kirill A. Shutemov
2020-04-03 11:29 ` [PATCHv2 3/8] khugepaged: Drain all LRU caches before scanning pages Kirill A. Shutemov
2020-04-06 18:15 ` Yang Shi
2020-04-03 11:29 ` [PATCHv2 4/8] khugepaged: Drain LRU add pagevec after swapin Kirill A. Shutemov
2020-04-06 13:11 ` Zi Yan
2020-04-06 18:29 ` Yang Shi
2020-04-08 13:05 ` Kirill A. Shutemov
2020-04-08 18:42 ` Yang Shi
2020-04-03 11:29 ` [PATCHv2 5/8] khugepaged: Allow to callapse a page shared across fork Kirill A. Shutemov
2020-04-06 20:15 ` Ralph Campbell
2020-04-06 20:50 ` Yang Shi
2020-04-08 13:10 ` Kirill A. Shutemov
2020-04-08 18:51 ` Yang Shi
2020-04-10 0:03 ` Yang Shi
2020-04-10 15:56 ` Kirill A. Shutemov
2020-04-06 21:30 ` John Hubbard
2020-04-10 15:55 ` Kirill A. Shutemov
2020-04-10 20:59 ` John Hubbard
2020-04-13 9:42 ` Kirill A. Shutemov
2020-04-03 11:29 ` [PATCHv2 6/8] khugepaged: Allow to collapse PTE-mapped compound pages Kirill A. Shutemov
2020-04-06 21:29 ` Yang Shi
2020-04-08 13:29 ` Kirill A. Shutemov
2020-04-08 18:57 ` Yang Shi
2020-04-09 13:47 ` Kirill A. Shutemov
2020-04-03 11:29 ` [PATCHv2 7/8] thp: Change CoW semantics for anon-THP Kirill A. Shutemov
2020-04-07 7:57 ` [thp] db001b7115: vm-scalability.median 8.9% improvement kernel test robot
2020-04-07 7:57 ` kernel test robot
2020-04-03 11:29 ` [PATCHv2 8/8] khugepaged: Introduce 'max_ptes_shared' tunable Kirill A. Shutemov
2020-04-06 13:17 ` Zi Yan
2020-04-05 23:40 ` [PATCHv2 0/8] thp/khugepaged improvements and CoW semantics William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71529d58-e51d-4f36-037d-42e60dd5a8ff@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.