RE: [PATCH 2/2] Intel-IOMMU, intr-remap: source-id checking

From: "Han, Weidong" <weidong.han@intel.com>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: RE: [PATCH 2/2] Intel-IOMMU, intr-remap: source-id checking
Date: Mon, 11 May 2009 14:22:54 +0800	[thread overview]
Message-ID: <715D42877B251141A38726ABF5CABF2C01A6DD4900@pdsmsx503.ccr.corp.intel.com> (raw)
In-Reply-To: <1241720381.27006.8582.camel@localhost.localdomain>

Siddha, Suresh B wrote:
> On Wed, 2009-05-06 at 23:16 -0700, Han, Weidong wrote:
>> @@ -634,6 +694,44 @@ static int ir_parse_ioapic_scope(struct
>>  			       acpi_dmar_header *header, " 0x%Lx\n",
>>  			       scope->enumeration_id, drhd->address);
>> 
>> +			bus = pci_find_bus(drhd->segment, scope->bus);
>> +			path = (struct acpi_dmar_pci_path *)(scope + 1); +			count =
>> (scope->length - +				 sizeof(struct acpi_dmar_device_scope))
>> +				/ sizeof(struct acpi_dmar_pci_path);
>> +
>> +			while (count) {
>> +				if (pdev)
>> +					pci_dev_put(pdev);
>> +
>> +				if (!bus)
>> +					break;
>> +
>> +				pdev = pci_get_slot(bus,
>> +					PCI_DEVFN(path->dev, path->fn));
>> +				if (!pdev)
>> +					break;
> 
> ir_parse_ioapic_scope() happens very early in the boot. So, I don't
> think we can do the pci related discovery here.
> 

Thanks for your pointing it out. It should enable the source-id checking for io-apic's after the pci subsystem is up. I will change it.

Regards,
Weidong