From: David Hildenbrand <david@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses
Date: Tue, 9 Jun 2020 17:51:22 +0200 [thread overview]
Message-ID: <725c9b77-3b5b-068e-10f9-011a44d66a29@redhat.com> (raw)
In-Reply-To: <20200609114608-mutt-send-email-mst@kernel.org>
On 09.06.20 17:47, Michael S. Tsirkin wrote:
> On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote:
>> E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices
>> results in
>> "virtio-pmem-pci not supported on this bus"
>>
>> Reasons is, that the bus does not support hotplug and, therefore, does
>> not have a hotplug handler. Let's allow coldplugging virtio-pmem devices
>> on such buses. The hotplug order is only relevant for virtio-pmem-pci
>> when the guest is already alive and the device is visible before
>> memory_device_plug() wired up the memory device bits.
>>
>> Hotplug attempts will still fail with:
>> "Error: Bus 'pcie.0' does not support hotplugging"
>>
>> Hotunplug attempts will still fail with:
>> "Error: Bus 'pcie.0' does not support hotplugging"
>>
>> Reported-by: Vivek Goyal <vgoyal@redhat.com>
>> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Richard Henderson <rth@twiddle.net>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>
> I assume you are still debugging Vivek's issues, right?
> Let me know when you feel it's time to merge this ...
The remain issue is lack of libvirt support. This is good to be merged
from my point of view.
Thanks!
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-06-09 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 8:45 [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses David Hildenbrand
2020-05-25 10:06 ` Pankaj Gupta
2020-05-26 13:28 ` Vivek Goyal
2020-05-26 13:44 ` David Hildenbrand
2020-05-26 14:22 ` Vivek Goyal
2020-05-26 14:43 ` David Hildenbrand
2020-05-26 14:56 ` Daniel P. Berrangé
2020-05-27 19:51 ` Pankaj Gupta
2020-06-09 15:47 ` Michael S. Tsirkin
2020-06-09 15:51 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=725c9b77-3b5b-068e-10f9-011a44d66a29@redhat.com \
--to=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.