From: Max Reitz <mreitz@redhat.com>
To: Sam Eiderman <shmuel.eiderman@oracle.com>,
kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: sagi.amit@oracle.com, arbel.moshe@oracle.com,
liran.alon@oracle.com, eyal.moscovici@oracle.com,
karl.heubaum@oracle.com
Subject: Re: [Qemu-devel] [PATCH v4 1/3] qemu-img: rebase: Reuse parent BlockDriverState
Date: Thu, 23 May 2019 18:13:26 +0200 [thread overview]
Message-ID: <72e53cec-c68f-5d47-9152-49551692880b@redhat.com> (raw)
In-Reply-To: <20190523154444.28783-2-shmuel.eiderman@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On 23.05.19 17:44, Sam Eiderman wrote:
> In safe mode we open the entire chain, including the parent backing
> file of the rebased file.
> Do not open a new BlockBackend for the parent backing file, which
> saves opening the rest of the chain twice, which for long chains
> saves many "pricy" bdrv_open() calls.
>
> Permissions for blk_new() were copied from blk_new_open() when
> flags = 0.
>
> Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
> Reviewed-by: Eyal Moscovici <eyal.moscovici@oracle.com>
> Signed-off-by: Sagi Amit <sagi.amit@oracle.com>
> Co-developed-by: Sagi Amit <sagi.amit@oracle.com>
> Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com>
> ---
> qemu-img.c | 29 +++++++++--------------------
> 1 file changed, 9 insertions(+), 20 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-23 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 15:44 [Qemu-devel] [PATCH v4 0/3] qemu-img: rebase: Improve/optimize rebase operation Sam Eiderman
2019-05-23 15:44 ` [Qemu-devel] [PATCH v4 1/3] qemu-img: rebase: Reuse parent BlockDriverState Sam Eiderman
2019-05-23 16:13 ` Max Reitz [this message]
2019-05-23 15:44 ` [Qemu-devel] [PATCH v4 2/3] qemu-img: rebase: Reduce reads on in-chain rebase Sam Eiderman
2019-05-23 16:14 ` Max Reitz
2019-05-23 16:35 ` Sam Eiderman
2019-05-23 15:44 ` [Qemu-devel] [PATCH v4 3/3] qemu-img: rebase: Reuse in-chain BlockDriverState Sam Eiderman
2019-05-23 16:14 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72e53cec-c68f-5d47-9152-49551692880b@redhat.com \
--to=mreitz@redhat.com \
--cc=arbel.moshe@oracle.com \
--cc=eyal.moscovici@oracle.com \
--cc=karl.heubaum@oracle.com \
--cc=kwolf@redhat.com \
--cc=liran.alon@oracle.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sagi.amit@oracle.com \
--cc=shmuel.eiderman@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.