From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Yang Li <yang.lee@linux.alibaba.com>, <davem@davemloft.net>
Cc: <kuba@kernel.org>, <geert@linux-m68k.org>,
<netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next v2] ethernet: renesas: Use div64_ul instead of do_div
Date: Thu, 18 Nov 2021 13:06:14 +0300 [thread overview]
Message-ID: <733ea341-7105-e552-f562-4fb362543088@omp.ru> (raw)
In-Reply-To: <1637228883-100100-1-git-send-email-yang.lee@linux.alibaba.com>
On 18.11.2021 12:48, Yang Li wrote:
> do_div() does a 64-by-32 division. Here the divisor is an
> unsigned long which on some platforms is 64 bit wide. So use
> div64_ul instead of do_div to avoid a possible truncation.
>
> Eliminate the following coccicheck warning:
> ./drivers/net/ethernet/renesas/ravb_main.c:2492:1-7: WARNING:
> do_div() does a 64-by-32 division, please consider using div64_ul
> instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
I haven't given you this tag, yet I was going to give you one, so
it's OK finally. :-)
[...]
MBR, Sergey
next prev parent reply other threads:[~2021-11-18 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 9:48 [PATCH -next v2] ethernet: renesas: Use div64_ul instead of do_div Yang Li
2021-11-18 10:06 ` Sergey Shtylyov [this message]
2021-11-20 4:30 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2021-11-18 2:58 Yang Li
2021-11-18 8:39 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=733ea341-7105-e552-f562-4fb362543088@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.