From: Julien Grall <julien@xen.org>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
paul@xen.org, Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH for-4.14 v2] x86/tlb: fix assisted flush usage
Date: Tue, 23 Jun 2020 16:08:06 +0100 [thread overview]
Message-ID: <741ff589-4366-1430-6639-13dc5f02fdfa@xen.org> (raw)
In-Reply-To: <20200623145006.66723-1-roger.pau@citrix.com>
Hi Roger,
On 23/06/2020 15:50, Roger Pau Monne wrote:
> diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
> index 9b62087be1..f360166f00 100644
> --- a/xen/include/xen/mm.h
> +++ b/xen/include/xen/mm.h
> @@ -639,7 +639,8 @@ static inline void accumulate_tlbflush(bool *need_tlbflush,
> }
> }
>
> -static inline void filtered_flush_tlb_mask(uint32_t tlbflush_timestamp)
> +static inline void filtered_flush_tlb_mask(uint32_t tlbflush_timestamp,
> + bool sync)
I read the commit message and went through the code, but it is still not
clear what "sync" means in a non-architectural way.
As an Arm developper, I would assume this means we don't wait for the
TLB flush to complete. But I am sure this would result to some
unexpected behavior.
So can you explain on non-x86 words what this really mean?
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2020-06-23 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 14:50 [PATCH for-4.14 v2] x86/tlb: fix assisted flush usage Roger Pau Monne
2020-06-23 15:08 ` Julien Grall [this message]
2020-06-23 15:15 ` Roger Pau Monné
2020-06-23 15:46 ` Julien Grall
2020-06-23 16:16 ` Roger Pau Monné
2020-06-24 11:10 ` Julien Grall
2020-06-25 9:33 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=741ff589-4366-1430-6639-13dc5f02fdfa@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.