From: Jiri Slaby <jirislaby@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Emil Renner Berthing <kernel@esmil.dk>,
Phil Edworthy <phil.edworthy@renesas.com>,
Johan Hovold <johan@kernel.org>,
linux-serial@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: dw: Fix the macro RZN1_UART_xDMACR_8_WORD_BURST
Date: Mon, 4 Jul 2022 08:35:54 +0200 [thread overview]
Message-ID: <7431817a-ed5e-1de6-9f69-fda2c1907861@kernel.org> (raw)
In-Reply-To: <20220630083909.4294-1-biju.das.jz@bp.renesas.com>
On 30. 06. 22, 10:39, Biju Das wrote:
> As per RZ/N1 peripheral user manual(r01uh0752ej0100-rzn1-peripheral.pdf)
> rev 1.0.0 Mar,2019,
Is this public anywhere?
> the value for 8_WORD_BURST is 4(b2,b1=2’b10).
>
> This patch fixes the macro as per the user manual.
I'm curious, is the bottom bit from "3" ignored by the HW or does this
fix a real problem in behavior? Stating that might help backporters to
decide if to take the patch or not.
> Fixes: aa63d786cea2 ("serial: 8250: dw: Add support for DMA flow controlling devices")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> drivers/tty/serial/8250/8250_dw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index f57bbd32ef11..931490b27d6b 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -47,7 +47,7 @@
> #define RZN1_UART_xDMACR_DMA_EN BIT(0)
> #define RZN1_UART_xDMACR_1_WORD_BURST (0 << 1)
> #define RZN1_UART_xDMACR_4_WORD_BURST (1 << 1)
> -#define RZN1_UART_xDMACR_8_WORD_BURST (3 << 1)
> +#define RZN1_UART_xDMACR_8_WORD_BURST (2 << 1)
> #define RZN1_UART_xDMACR_BLK_SZ(x) ((x) << 3)
>
> /* Quirks */
thanks,
--
js
next prev parent reply other threads:[~2022-07-04 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 8:39 [PATCH] serial: 8250: dw: Fix the macro RZN1_UART_xDMACR_8_WORD_BURST Biju Das
2022-06-30 9:36 ` Phil Edworthy
2022-07-04 6:35 ` Jiri Slaby [this message]
2022-07-04 7:12 ` Biju Das
2022-07-05 6:23 ` Biju Das
2022-07-05 9:30 ` Andy Shevchenko
2022-07-05 13:30 ` Biju Das
2022-07-05 16:31 ` Serge Semin
2022-07-10 8:46 ` Biju Das
2022-07-11 11:02 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7431817a-ed5e-1de6-9f69-fda2c1907861@kernel.org \
--to=jirislaby@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kernel@esmil.dk \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.