From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Andrei Rybak <rybak.a.v@gmail.com>, git@vger.kernel.org
Cc: Barret Rhoden <brho@google.com>
Subject: Re: [PATCH v2] blame: correct name of config option in docs
Date: Sun, 20 Jun 2021 16:37:36 +0700 [thread overview]
Message-ID: <744f5e3e-808e-3ea1-9f3a-892c3936dcbd@gmail.com> (raw)
In-Reply-To: <20210619112912.76136-1-rybak.a.v@gmail.com>
On 19/06/21 18.29, Andrei Rybak wrote:
> As can be seen in files "Documentation/blame-options.txt" and
> "builtin/blame.c", the name of this configuration option is
> "blame.markUnblamableLines".
>
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
>
> Thanks to Bagas Sanjaya for review. Changes since v1:
>
> - tweaked commit message
>
> Range-diff:
>
> 1: e32c298ee8 ! 1: 6ea64765e7 blame: fix typo in documentation
> @@ Metadata
> Author: Andrei Rybak <rybak.a.v@gmail.com>
>
> ## Commit message ##
> - blame: fix typo in documentation
> + blame: correct name of config option in docs
>
> As can be seen in files "Documentation/blame-options.txt" and
> - "builtin/blame.c", the name of this configuration variable is
> + "builtin/blame.c", the name of this configuration option is
> "blame.markUnblamableLines".
>
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
>
> Documentation/config/blame.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/config/blame.txt b/Documentation/config/blame.txt
> index 9468e8599c..4d047c1790 100644
> --- a/Documentation/config/blame.txt
> +++ b/Documentation/config/blame.txt
> @@ -27,7 +27,7 @@ blame.ignoreRevsFile::
> file names will reset the list of ignored revisions. This option will
> be handled before the command line option `--ignore-revs-file`.
>
> -blame.markUnblamables::
> +blame.markUnblamableLines::
> Mark lines that were changed by an ignored revision that we could not
> attribute to another commit with a '*' in the output of
> linkgit:git-blame[1].
>
Looks OK, thanks for contributing.
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-06-20 9:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 22:11 [PATCH] blame: fix typo in documentation Andrei Rybak
2021-06-19 5:27 ` Bagas Sanjaya
2021-06-19 11:12 ` Andrei Rybak
2021-06-19 11:20 ` Bagas Sanjaya
2021-06-19 17:31 ` Felipe Contreras
2021-06-19 11:29 ` [PATCH v2] blame: correct name of config option in docs Andrei Rybak
2021-06-20 9:37 ` Bagas Sanjaya [this message]
2021-06-21 16:57 ` Barret Rhoden
2021-06-25 19:38 ` [PATCH v3 0/3] Config option names typofixes Andrei Rybak
2021-06-25 19:38 ` [PATCH v3 1/3] blame: correct name of config option in docs Andrei Rybak
2021-06-25 19:38 ` [PATCH v3 2/3] t: fix typos in test messages Andrei Rybak
2021-06-25 19:38 ` [PATCH v3 3/3] git-worktree.txt: fix typo in example path Andrei Rybak
2021-06-26 6:58 ` Carlo Marcelo Arenas Belón
2021-06-26 10:07 ` Andrei Rybak
2021-06-29 1:12 ` Junio C Hamano
2021-06-26 11:50 ` [PATCH v3 0/3] Config option names typofixes Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744f5e3e-808e-3ea1-9f3a-892c3936dcbd@gmail.com \
--to=bagasdotme@gmail.com \
--cc=brho@google.com \
--cc=git@vger.kernel.org \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.