From: Andrew Price <anprice@redhat.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 02/12] fs_parse: fix fs_param_v_optional handling
Date: Fri, 29 Nov 2019 15:56:39 +0000 [thread overview]
Message-ID: <74a0ccaa-4235-6c68-0f6f-a8954a827e06@redhat.com> (raw)
In-Reply-To: <CAOssrKccHtfwg4SYbQRwoaz_WcWJWNM3JXk7BHv=SPpsKOdkuQ@mail.gmail.com>
On 29/11/2019 14:43, Miklos Szeredi wrote:
> On Fri, Nov 29, 2019 at 12:31 PM Andrew Price <anprice@redhat.com> wrote:
>>
>> On 28/11/2019 15:59, Miklos Szeredi wrote:
>>> String options always have parameters, hence the check for optional
>>> parameter will never trigger.
>>>
>>> Check for param type being a flag first (flag is the only type that does
>>> not have a parameter) and report "Missing value" if the parameter is
>>> mandatory.
>>>
>>> Tested with gfs2's "quota" option, which is currently the only user of
>>> fs_param_v_optional.
>>
>> It's not clear to me what the bug is here. My tests with the quota
>> option are giving expected results. Perhaps I missed a case?
>
> fsopen-test-2: fsconfig(3, FSCONFIG_SET_FLAG, "quota", NULL, 0):
> Invalid argument
> fsopen-test-2: context log: <e gfs2: Bad value for 'quota'>
>
> kernel: 5.4.0-08836-g81b6b96475ac
Ah right, gotcha. My tests were relying on the same codepaths being used
from the legacy/monolithic parsing code.
Reviewed-by: Andrew Price <anprice@redhat.com>
Andy
next prev parent reply other threads:[~2019-11-29 15:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 15:59 [PATCH 00/12] various vfs patches Miklos Szeredi
2019-11-28 15:59 ` [PATCH 01/12] aio: fix async fsync creds Miklos Szeredi
2019-12-13 9:32 ` Miklos Szeredi
2020-05-04 8:05 ` Avi Kivity
2019-11-28 15:59 ` [PATCH 02/12] fs_parse: fix fs_param_v_optional handling Miklos Szeredi
2019-11-29 11:31 ` Andrew Price
2019-11-29 14:43 ` Miklos Szeredi
2019-11-29 15:56 ` Andrew Price [this message]
2019-12-16 23:28 ` Al Viro
2019-12-17 1:18 ` Al Viro
2019-12-17 3:27 ` Al Viro
2019-11-28 15:59 ` [PATCH 03/12] vfs: verify param type in vfs_parse_sb_flag() Miklos Szeredi
2019-11-28 15:59 ` [PATCH 04/12] uapi: deprecate STATX_ALL Miklos Szeredi
2019-11-28 15:59 ` [PATCH 05/12] statx: don't clear STATX_ATIME on SB_RDONLY Miklos Szeredi
2019-11-28 15:59 ` [PATCH 06/12] utimensat: AT_EMPTY_PATH support Miklos Szeredi
2019-11-28 15:59 ` [PATCH 07/12] f*xattr: allow O_PATH descriptors Miklos Szeredi
2019-12-03 9:20 ` [LTP] [f*xattr] f4cecda4a3: ltp.open13.fail kernel test robot
2019-12-03 9:20 ` kernel test robot
2019-11-28 15:59 ` [PATCH 08/12] vfs: allow unprivileged whiteout creation Miklos Szeredi
2019-12-17 3:51 ` Al Viro
2019-12-17 4:22 ` Miklos Szeredi
2019-11-28 15:59 ` [PATCH 09/12] fs_parser: "string" with missing value is a "flag" Miklos Szeredi
2019-12-17 17:32 ` Al Viro
2019-12-17 18:31 ` Al Viro
2019-11-28 15:59 ` [PATCH 10/12] vfs: don't parse forbidden flags Miklos Szeredi
2019-11-28 15:59 ` [PATCH 11/12] vfs: don't parse "posixacl" option Miklos Szeredi
2019-12-17 3:42 ` Al Viro
2019-12-17 4:18 ` Miklos Szeredi
2019-12-17 4:28 ` Al Viro
2019-11-28 15:59 ` [PATCH 12/12] vfs: don't parse "silent" option Miklos Szeredi
2019-12-17 3:37 ` Al Viro
2019-12-17 4:12 ` Miklos Szeredi
2019-12-17 4:16 ` Miklos Szeredi
2019-12-17 4:19 ` Al Viro
2019-12-17 4:23 ` Miklos Szeredi
2019-12-17 4:28 ` Miklos Szeredi
2019-12-17 4:17 ` Al Viro
2019-12-13 9:33 ` [PATCH 00/12] various vfs patches Miklos Szeredi
2019-12-16 23:13 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74a0ccaa-4235-6c68-0f6f-a8954a827e06@redhat.com \
--to=anprice@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.