From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>
Subject: Re: [PATCH v5 03/13] btrfs: introduce a new helper to submit read bio for scrub
Date: Tue, 28 Mar 2023 09:10:58 +0800 [thread overview]
Message-ID: <75000ec0-cb6b-9d44-0ec1-0683a80f8094@gmx.com> (raw)
In-Reply-To: <ZCI9ILRIa2G8WzWE@infradead.org>
On 2023/3/28 09:04, Christoph Hellwig wrote:
> On Tue, Mar 28, 2023 at 09:01:57AM +0800, Qu Wenruo wrote:
>>> Well, if did just call btrfs_submit_chunk, the RST lookup would ensure
>>> you only get the length of the RST mapping, and you get the behavior
>>> you want without duplication. We'd need to make it non-static (and
>>> document it), but I'd still be much happier about that than yet another
>>> I/O submission interface.
>>
>> But in that case, wouldn't we just error out?
>
> btrfs_submit_chunk is greedy. But yes, if there was no mapping at all
> I guess it would error out and we'd need to find a way to handle that.
> But that still seems better than duplicating the logic again.
Well, to me the whole btrfs_submit_chunk() is already super modular
(great work from you, very appreciated), thus new scrub_read path only
goes less than 30 lines.
At least to me, a few more lines for a special path seems worthy.
Especially when that scrub path should never be utilized by anyone else.
But I'm still open minded to merge if proven the change is small enough.
Let us see what we can do after the next update of RST patchset and
determine then.
Thanks,
Qu
next prev parent reply other threads:[~2023-03-28 1:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 23:30 [PATCH v5 00/13] btrfs: scrub: use a more reader friendly code to implement scrub_simple_mirror() Qu Wenruo
2023-03-27 23:30 ` [PATCH v5 01/13] btrfs: scrub: use dedicated super block verification function to scrub one super block Qu Wenruo
2023-03-27 23:30 ` [PATCH v5 02/13] btrfs: introduce a new allocator for scrub specific btrfs_bio Qu Wenruo
2023-03-27 23:30 ` [PATCH v5 03/13] btrfs: introduce a new helper to submit read bio for scrub Qu Wenruo
2023-03-27 23:35 ` Christoph Hellwig
2023-03-28 0:16 ` Qu Wenruo
2023-03-28 0:25 ` Christoph Hellwig
2023-03-28 0:48 ` Qu Wenruo
2023-03-28 0:53 ` Christoph Hellwig
2023-03-28 1:01 ` Qu Wenruo
2023-03-28 1:04 ` Christoph Hellwig
2023-03-28 1:10 ` Qu Wenruo [this message]
2023-03-27 23:30 ` [PATCH v5 04/13] btrfs: introduce a new helper to submit write " Qu Wenruo
2023-03-27 23:30 ` [PATCH v5 05/13] btrfs: scrub: introduce the structure for new BTRFS_STRIPE_LEN based interface Qu Wenruo
2023-03-27 23:30 ` [PATCH v5 06/13] btrfs: scrub: introduce a helper to find and fill the sector info for a scrub_stripe Qu Wenruo
2023-03-27 23:30 ` [PATCH v5 07/13] btrfs: scrub: introduce a helper to verify one metadata Qu Wenruo
2023-03-27 23:30 ` [PATCH v5 08/13] btrfs: scrub: introduce a helper to verify one scrub_stripe Qu Wenruo
2023-03-27 23:30 ` [PATCH v5 09/13] btrfs: scrub: introduce the main read repair worker for scrub_stripe Qu Wenruo
2023-03-27 23:31 ` [PATCH v5 10/13] btrfs: scrub: introduce a writeback helper " Qu Wenruo
2023-03-27 23:31 ` [PATCH v5 11/13] btrfs: scrub: introduce error reporting functionality " Qu Wenruo
2023-03-27 23:31 ` [PATCH v5 12/13] btrfs: scrub: introduce the helper to queue a stripe for scrub Qu Wenruo
2023-03-27 23:31 ` [PATCH v5 13/13] btrfs: scrub: switch scrub_simple_mirror() to scrub_stripe infrastructure Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75000ec0-cb6b-9d44-0ec1-0683a80f8094@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.