From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
bertrand.marquis@arm.com, wei.chen@arm.com
Subject: Re: [PATCH v3 07/10] xen/arm: Always access SCTLR_EL2 using READ/WRITE_SYSREG()
Date: Wed, 5 May 2021 19:07:58 +0100 [thread overview]
Message-ID: <758c4de0-f31e-78fc-7db6-878acb5f6f54@xen.org> (raw)
In-Reply-To: <20210505074308.11016-8-michal.orzel@arm.com>
Hi Michal,
On 05/05/2021 08:43, Michal Orzel wrote:
> The Armv8 specification describes the system register as a 64-bit value
> on AArch64 and 32-bit value on AArch32 (same as ARMv7).
>
> Unfortunately, Xen is accessing the system registers using
> READ/WRITE_SYSREG32() which means the top 32-bit are clobbered.
>
> This is only a latent bug so far because Xen will not yet use the top
> 32-bit.
>
> There is also no change in behavior because arch/arm/arm64/head.S will
> initialize SCTLR_EL2 to a sane value with the top 32-bit zeroed.
>
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2021-05-05 18:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 7:42 [PATCH v3 00/10] arm64: Get rid of READ/WRITE_SYSREG32 Michal Orzel
2021-05-05 7:42 ` [PATCH v3 01/10] arm64/vfp: " Michal Orzel
2021-05-05 7:43 ` [PATCH v3 02/10] arm/domain: " Michal Orzel
2021-05-05 18:03 ` Julien Grall
2021-05-06 6:13 ` Michal Orzel
2021-05-10 17:02 ` Julien Grall
2021-05-05 7:43 ` [PATCH v3 03/10] arm: Modify type of actlr to register_t Michal Orzel
2021-05-05 18:04 ` Julien Grall
2021-05-05 7:43 ` [PATCH v3 04/10] arm/gic: Remove member hcr of structure gic_v3 Michal Orzel
2021-05-05 7:43 ` [PATCH v3 05/10] arm/gic: Get rid of READ/WRITE_SYSREG32 Michal Orzel
2021-05-05 18:06 ` Julien Grall
2021-05-05 7:43 ` [PATCH v3 06/10] arm/p2m: " Michal Orzel
2021-05-05 7:43 ` [PATCH v3 07/10] xen/arm: Always access SCTLR_EL2 using READ/WRITE_SYSREG() Michal Orzel
2021-05-05 18:07 ` Julien Grall [this message]
2021-05-05 7:43 ` [PATCH v3 08/10] arm/page: Get rid of READ/WRITE_SYSREG32 Michal Orzel
2021-05-05 7:43 ` [PATCH v3 09/10] arm/time,vtimer: " Michal Orzel
2021-05-05 7:43 ` [PATCH v3 10/10] arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t Michal Orzel
2021-05-05 8:00 ` Jan Beulich
2021-05-05 11:49 ` Tamas K Lengyel
2021-05-11 6:37 ` Michal Orzel
2021-05-12 17:59 ` Julien Grall
2021-05-12 18:14 ` Andrew Cooper
2021-05-17 7:01 ` Jan Beulich
2021-05-17 16:03 ` Julien Grall
2021-05-21 6:33 ` Michal Orzel
2021-05-21 7:07 ` Jan Beulich
2021-06-07 13:16 ` Michal Orzel
2021-06-07 13:31 ` Julien Grall
2021-07-01 8:19 ` Michal Orzel
2021-07-03 14:42 ` Julien Grall
2021-05-10 17:19 ` [PATCH v3 00/10] arm64: Get rid of READ/WRITE_SYSREG32 Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=758c4de0-f31e-78fc-7db6-878acb5f6f54@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=michal.orzel@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.