From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: ti: davinci-i2s: Add check for clk_enable()
Date: Mon, 28 Feb 2022 14:24:59 +0200 [thread overview]
Message-ID: <764a2715-9c24-25f0-74ee-c9cf5d8a46c6@gmail.com> (raw)
In-Reply-To: <20220228031540.3571959-1-jiasheng@iscas.ac.cn>
On 28/02/2022 05:15, Jiasheng Jiang wrote:
> As the potential failure of the clk_enable(),
> it should be better to check it and return error
> if fails.
Thank you for the patch!
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
>
> Fixes: 5f9a50c3e55e ("ASoC: Davinci: McBSP: add device tree support for McBSP")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> sound/soc/ti/davinci-i2s.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/ti/davinci-i2s.c b/sound/soc/ti/davinci-i2s.c
> index 6dca51862dd7..0363a088d2e0 100644
> --- a/sound/soc/ti/davinci-i2s.c
> +++ b/sound/soc/ti/davinci-i2s.c
> @@ -708,7 +708,9 @@ static int davinci_i2s_probe(struct platform_device *pdev)
> dev->clk = clk_get(&pdev->dev, NULL);
> if (IS_ERR(dev->clk))
> return -ENODEV;
> - clk_enable(dev->clk);
> + ret = clk_enable(dev->clk);
> + if (ret)
> + goto err_put_clk;
>
> dev->dev = &pdev->dev;
> dev_set_drvdata(&pdev->dev, dev);
> @@ -730,6 +732,7 @@ static int davinci_i2s_probe(struct platform_device *pdev)
> snd_soc_unregister_component(&pdev->dev);
> err_release_clk:
> clk_disable(dev->clk);
> +err_put_clk:
> clk_put(dev->clk);
> return ret;
> }
--
Péter
next prev parent reply other threads:[~2022-02-28 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 3:15 [PATCH] ASoC: ti: davinci-i2s: Add check for clk_enable() Jiasheng Jiang
2022-02-28 3:15 ` Jiasheng Jiang
2022-02-28 12:24 ` Péter Ujfalusi [this message]
2022-02-28 19:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764a2715-9c24-25f0-74ee-c9cf5d8a46c6@gmail.com \
--to=peter.ujfalusi@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jiasheng@iscas.ac.cn \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.