From: "Konduru, Chandra" <chandra.konduru@intel.com>
To: 'Daniel Stone' <daniel@fooishbar.org>,
"Kannan, Vandana" <vandana.kannan@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [RFC 2/2] drm/i915: Render decompression support for Gen9
Date: Tue, 12 Jan 2016 00:39:15 +0000 [thread overview]
Message-ID: <76A9B330A4D78C4D99CB292C4CC06C0E372348E6@fmsmsx101.amr.corp.intel.com> (raw)
In-Reply-To: <CAPj87rO1kUbE1-y9LRRW7y0cH0KSnCz0RU6Uo+TEwzC++dgLBQ@mail.gmail.com>
> -----Original Message-----
> From: Daniel Stone [mailto:daniel@fooishbar.org]
> Sent: Wednesday, December 23, 2015 1:37 AM
> To: Kannan, Vandana
> Cc: intel-gfx; Konduru, Chandra; Murthy, Arun R
> Subject: Re: [Intel-gfx] [RFC 2/2] drm/i915: Render decompression support for
> Gen9
>
> Hi Vandana,
>
> On 23 December 2015 at 03:20, Kannan, Vandana
> <vandana.kannan@intel.com> wrote:
> > How does VT switch work in case of rotation, setting different pixel format,
> > etc?
>
> Pixel format is a property of the framebuffer, not a per-plane
> property, so is unaffected. Rotation is generic, so there is specific
> code to handle it for fbdev etc.
>
> But the real problem is that this is an Intel-specific property, and
> in order to get correct results, userspace must know about these
> specific properties in order to unset them. This means that you can't
> run generic userspace, and you can't run old userspace which predates
> these properties either. This seems like a total non-starter to me.
>
> It would be much cleaner if there was a way to attach the render
> compression property to the framebuffer, e.g. by using the format
> modifiers which were specifically introduced to deal with compression
> and tiling.
>
> Cheers,
> Daniel
Hi Daniel,
Plan is to handle compression property similar to rotation property.
Don't see why that will be an issue.
To address VT-switch concern, there will be a small code change
resetting compression property in the VT-switch case - which may as well
apply to other properties.
Please let us know if this is resolving your feedback.
By the way, for rotation in VT switch path (or any other property),
there isn't code to reset to 0. The only place where reset is at
"i915_driver_lastclose - clean up after all DRM clients have exited".
Thanks,
Chandra
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-01-12 0:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 5:15 [RFC 1/2] drm: Add aux plane verification in addFB2 Vandana Kannan
2015-12-09 5:15 ` [RFC 2/2] drm/i915: Render decompression support for Gen9 Vandana Kannan
2015-12-09 18:05 ` Daniel Stone
2015-12-23 3:20 ` Kannan, Vandana
2015-12-23 9:37 ` Daniel Stone
2016-01-12 0:39 ` Konduru, Chandra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76A9B330A4D78C4D99CB292C4CC06C0E372348E6@fmsmsx101.amr.corp.intel.com \
--to=chandra.konduru@intel.com \
--cc=daniel@fooishbar.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vandana.kannan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.