Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: qemu-s390x@nongnu.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-devel@nongnu.org, ldoktor@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds
Date: Thu, 29 Mar 2018 15:23:24 +0200	[thread overview]
Message-ID: <76c9cfb5-504c-9490-35bc-0297b3c960a9@redhat.com> (raw)
In-Reply-To: <20180329151505.36a28a74.cohuck@redhat.com>

On 29.03.2018 15:15, Cornelia Huck wrote:
> On Thu, 29 Mar 2018 11:37:31 +0200
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> The current timeout is set to only three seconds - and considering that
>> vring_wait_reply() or rather get_second() is not doing any rounding,
>> the real timeout is likely rather 2 seconds in most cases. When the
>> host is really badly loaded and we run the guest in TCG mode instead
>> of KVM, it's possible that we hit this timeout by mistake. 
> 
> Let's tweak this sentence to
> 
> "When the host is really badly loaded, it's possible that we hit this
> timeout by mistake; it's even more likely if we run the guest in TCG
> mode instead of KVM."
> 
> ?

Fine for me. You could even remove that TCG vs. KVM part if you like.

 Thomas