Re: [PATCH -next v2 19/21] spi: dw: switch to use modern name

From: Yang Yingliang <yangyingliang@huawei.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	<linux-spi@vger.kernel.org>, <broonie@kernel.org>,
	<lukas@wunner.de>, <yangyingliang@huawei.com>
Subject: Re: [PATCH -next v2 19/21] spi: dw: switch to use modern name
Date: Wed, 16 Aug 2023 17:29:04 +0800	[thread overview]
Message-ID: <770c965d-a08c-760a-f315-f546254053ec@huawei.com> (raw)
In-Reply-To: <rjwaprnnlkpkohzdq5iapcmvx4uayc4tvdr2nny3s5olhphqvs@iusqjo6na75w>


On 2023/8/16 17:24, Serge Semin wrote:
> Hi Yang
>
> On Wed, Aug 16, 2023 at 11:45:26AM +0800, Yang Yingliang wrote:
>> Hi Serge,
>>
>> On 2023/8/15 19:36, Geert Uytterhoeven wrote:
>>> Hi Yang,
>>>
>>> On Mon, Aug 7, 2023 at 4:10 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
>>>> Change legacy name master to modern name host or controller.
>>>>
>>>> No functional changed.
>>>>
>>>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>>> Thanks for your patch, which is now commit eefc6c5c2451126c ("spi:
>>> dw: switch to use modern name") in spi/for-next.
>>>
>>>> --- a/drivers/spi/spi-dw-mmio.c
>>>> +++ b/drivers/spi/spi-dw-mmio.c
>>>> @@ -68,7 +68,7 @@ struct dw_spi_mscc {
>>>>                   ((((val) << 1) | BIT(0)) << ELBA_SPICS_OFFSET(cs))
>>>>
>>>>    /*
>>>> - * The Designware SPI controller (referred to as master in the documentation)
>>>> + * The Designware SPI controller (referred to as host in the documentation)
>>>>     * automatically deasserts chip select when the tx fifo is empty. The chip
>>>>     * selects then needs to be either driven as GPIOs or, for the first 4 using
>>>>     * the SPI boot controller registers. the final chip select is an OR gate
>>> Have you verified that Synopsys did update the documentation for the
>>> Designware SPI controller?  If not, I think it's prudent to keep the
>>> old name.
>> I'm trying to rename the legacy name(master/slave) to modern
>> name(host/target) used in SPI drivers,
>> is it ok to change this comment master to host ?
> The latest Synopsys DesignWare HW databook I posses is of DW APB SSI
> 4.03a IP-core dated by 12.2020. It still uses the master/slave
> wording. The same words can be found in the modern DW AMBA
> Interconnect datasheets:
> https://www.synopsys.com/dw/doc.php/ds/i/dw_amba_solutions.pdf
> (fill in the form with your corporate personal data and you'll be able
> to read the doc)
> I doubt Synopsys has been in anyway concerned about the renaming.  So
> the in-situ comment Geert correctly noted should be left as is: using
> the "master" word in this context.
OK. I will send a patch change it back.

Thanks,
Yang
>
> -Serge(y)
>
>> Thanks,
>> Yang
>>>> @@ -142,14 +142,14 @@ static int dw_spi_mscc_jaguar2_init(struct platform_device *pdev,
>>>>    }
>>>>
>>>>    /*
>>>> - * The Designware SPI controller (referred to as master in the
>>>> + * The Designware SPI controller (referred to as host in the
>>> Likewise.
>>>
>>>>     * documentation) automatically deasserts chip select when the tx fifo
>>>>     * is empty. The chip selects then needs to be driven by a CS override
>>>>     * register. enable is an active low signal.
>>>>     */
>>>>    static void dw_spi_sparx5_set_cs(struct spi_device *spi, bool enable)
>>>>    {
>>> Gr{oetje,eeting}s,
>>>
>>>                           Geert
>>>
>>> --
>>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>>>
>>> In personal conversations with technical people, I call myself a hacker. But
>>> when I'm talking to journalists I just say "programmer" or something like that.
>>>                                   -- Linus Torvalds
>>>
>>> .
> .