From: Hauke Mehrtens <hauke@hauke-m.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: backports@vger.kernel.org, john@phrozen.org
Subject: Re: [PATCH 08/10] patches: remove .coredump from struct driver for kernel < 4.16
Date: Mon, 24 Sep 2018 22:20:03 +0200 [thread overview]
Message-ID: <77307628-5584-e5d1-255e-b730c201dc91@hauke-m.de> (raw)
In-Reply-To: <1537778165.1707.26.camel@sipsolutions.net>
[-- Attachment #1.1: Type: text/plain, Size: 775 bytes --]
On 09/24/2018 10:36 AM, Johannes Berg wrote:
> On Sun, 2018-09-23 at 19:45 +0200, Hauke Mehrtens wrote:
>> Kernel 4.16 added a new .coredump member to the driver structure which
>> can be implemented by drivers. Remove this member on older kernel
>> versions as they do not support this feature.
>
> Note that this isn't sufficient.
>
> On 4.16, the return value was int, now it's void. I'll change this patch
> to be for < 4.17, but if somebody wants to submit an spatch to fix up
> the difference that would work too.
>
> johannes
>
Thanks for fixing this, I didn't noticed that this changed between 4.16
and 4.17. I think it is ok to only provide this on kernel >= 4.17, this
is an not essential feature and 4.16 is not a long term kernel.
Hauke
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-09-25 2:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 17:45 [PATCH 00/10] backports: misc fixes to improve support of 4.19 Hauke Mehrtens
2018-09-23 17:45 ` [PATCH 01/10] backports: Remove ssb and bcma Hauke Mehrtens
2018-09-23 20:10 ` Johannes Berg
2018-09-23 20:18 ` Hauke Mehrtens
2018-09-24 10:48 ` Johannes Berg
2018-09-24 20:17 ` Hauke Mehrtens
2018-09-23 17:45 ` [PATCH 02/10] backports: Remove NFC support Hauke Mehrtens
2018-09-23 17:45 ` [PATCH 03/10] copy: Add crc32poly.h Hauke Mehrtens
2018-09-23 17:45 ` [PATCH 04/10] dependencies: Make RSI_COEX coexistence depend on kernel >= 4.17 Hauke Mehrtens
2018-09-23 20:20 ` Johannes Berg
2018-09-23 17:45 ` [PATCH 05/10] dependencies: Make WIL6210 depend on kernel >= 4.8 Hauke Mehrtens
2018-09-23 20:12 ` Johannes Berg
2018-09-23 20:36 ` Hauke Mehrtens
2018-09-23 17:45 ` [PATCH 06/10] dependencies: make hostap and atmel depend on kernel >= 4.18 Hauke Mehrtens
2018-09-23 20:17 ` Johannes Berg
2018-09-23 20:23 ` Hauke Mehrtens
2018-09-23 20:33 ` Johannes Berg
2018-09-23 17:45 ` [PATCH 07/10] patches: make mt76 use skb_pad() instead of __skb_pad() Hauke Mehrtens
2018-09-23 17:45 ` [PATCH 08/10] patches: remove .coredump from struct driver for kernel < 4.16 Hauke Mehrtens
2018-09-24 8:36 ` Johannes Berg
2018-09-24 20:20 ` Hauke Mehrtens [this message]
2018-09-23 17:45 ` [PATCH 09/10] backports: Make netdev destructor spatch apply correctly again Hauke Mehrtens
2018-09-23 20:17 ` Johannes Berg
2018-09-23 17:45 ` [PATCH 10/10] patches: Do not remove linux/kmemleak.h include Hauke Mehrtens
2018-09-23 20:18 ` Johannes Berg
2018-09-24 8:12 ` [PATCH 00/10] backports: misc fixes to improve support of 4.19 Johannes Berg
2018-09-24 20:27 ` Hauke Mehrtens
2018-09-24 20:28 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77307628-5584-e5d1-255e-b730c201dc91@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=backports@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=john@phrozen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.