Re: [PATCH 2/3] xen/arm: vgic: Use 'unsigned int' rather than 'int' whenever it is possible

From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH 2/3] xen/arm: vgic: Use 'unsigned int' rather than 'int' whenever it is possible
Date: Mon, 21 Aug 2023 18:00:56 +0100	[thread overview]
Message-ID: <778b0a63-0d2b-47c9-8dc5-21717e3e1eb5@xen.org> (raw)
In-Reply-To: <e3258b25-99fe-5c4a-e539-06b08fe85e2f@amd.com>

Hi Michal,

On 18/08/2023 08:02, Michal Orzel wrote:
> On 17/08/2023 23:43, Julien Grall wrote:
>>
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Switch to unsigned int for the return/parameters of the following
>> functions:
>>      * REG_RANK_NR(): 'b' (number of bits) and the return is always positive.
>>        'n' doesn't need to be size specific.
>>      * vgic_rank_offset(): 'b' (number of bits), 'n' (register index),
>>        's' (size of the access) are always positive.
>>      * vgic_{enable, disable}_irqs(): 'n' (rank index) is always positive
>>      * vgic_get_virq_type(): 'n' (rank index) and 'index' (register
>>        index) are always positive.
> It looks like you forgot to mention the modification done to 'vgic_get_rank()'

I have added:

         * vgic_get_rank(): 'rank' is an index and therefore always 
positive.

> With this addressed:
> Reviewed-by: Michal Orzel <michal.orzel@amd.com>

Thanks!

Cheers,

-- 
Julien Grall