Re: [PATCH 2/5] KVM: VMX: Read cached VM-Exit reason to detect external interrupt

From: Paolo Bonzini <pbonzini@redhat.com>
To: "Sean Christopherson" <sean.j.christopherson@intel.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Joerg Roedel" <joro@8bytes.org>
Cc: kvm@vger.kernel.org, Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH 2/5] KVM: VMX: Read cached VM-Exit reason to detect external interrupt
Date: Thu, 6 Jun 2019 15:02:02 +0200	[thread overview]
Message-ID: <77943c3f-405e-9cab-7535-cbe9cb1fc89b@redhat.com> (raw)
In-Reply-To: <20190420055059.16816-3-sean.j.christopherson@intel.com>

On 20/04/19 07:50, Sean Christopherson wrote:
> Generic x86 code blindly invokes the dedicated external interrupt
> handler blindly, i.e. vmx_handle_external_intr() is called on all
> VM-Exits regardless of the actual exit type.

That's *really* blindly. :)  Rephrased to

    Generic x86 code invokes the kvm_x86_ops external interrupt handler
    on all VM-Exits regardless of the actual exit type.

-		unsigned long entry;
-		gate_desc *desc;
+	unsigned long entry;

I'd rather keep the desc variable to simplify review (with "diff -b")
and because the code is more readable that way.  Unless you have a
strong reason not to do so, I can do the change when applying.

Paolo