From: Eric Blake <eblake@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com,
qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH] iotests: Dump QCOW2 dirty bitmaps metadata
Date: Tue, 26 May 2020 13:58:00 -0500 [thread overview]
Message-ID: <77e7c8ab-d412-a5ca-0b8a-b07e4862d143@redhat.com> (raw)
In-Reply-To: <1590504866-679474-1-git-send-email-andrey.shinkevich@virtuozzo.com>
On 5/26/20 9:54 AM, Andrey Shinkevich wrote:
> Add dirty bitmap information to QCOW2 metadata dump in qcow2.py script.
> The sample output:
>
> Header extension (Bitmaps):
This change to the output is independently useful. However, per
patchew, it does cause 'make check' to fail:
https://patchew.org/logs/1590504866-679474-1-git-send-email-andrey.shinkevich@virtuozzo.com/testing.docker-quick@centos7/?type=message
...
--- /tmp/qemu-test/src/tests/qemu-iotests/031.out 2020-05-26
14:44:51.000000000 +0000
+++ /tmp/qemu-test/build/tests/qemu-iotests/031.out.bad 2020-05-26
18:07:11.753556518 +0000
@@ -24,7 +24,7 @@
refcount_order 4
header_length 72
-Header extension:
+Header extension (Unknown):
...
Failures: 031 036 061
I think it would be wise to split this into two patches, one that makes
_just_ the following change:
> @@ -143,30 +267,39 @@ class QcowHeader:
> print("%-25s" % f[2], value_str)
> print("")
>
> - def dump_extensions(self):
> + def dump_extensions(self, fd):
> for ex in self.extensions:
>
> + print("Header extension (%s):" % self.extension_name(ex.magic))
> + print("%-25s %#x" % ("magic", ex.magic))
> + print("%-25s %d" % ("length", ex.length))
and whatever is needed to support that, plus the changes necessary to
the iotests output to keep them passing (hopefully, the 3 tests
identified by 'make check' covers all of the existing tests already
using qcow2.py), then the second patch adding the rest of this that then
gives details about the bitmap contents.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2020-05-26 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 14:54 [PATCH] iotests: Dump QCOW2 dirty bitmaps metadata Andrey Shinkevich
2020-05-26 18:16 ` no-reply
2020-05-26 18:58 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77e7c8ab-d412-a5ca-0b8a-b07e4862d143@redhat.com \
--to=eblake@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.