From: Thomas Huth <thuth@redhat.com>
To: David Hildenbrand <david@redhat.com>, kvm@vger.kernel.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>
Subject: Re: [kvm-unit-tests PATCH v3 4/7] s390x: compile sclp-ascii.c
Date: Mon, 22 May 2017 11:47:38 +0200 [thread overview]
Message-ID: <78138122-02c8-6744-4dcf-9ff7ba8e3b30@redhat.com> (raw)
In-Reply-To: <20170522085702.17856-5-david@redhat.com>
On 22.05.2017 10:56, David Hildenbrand wrote:
> We can reuse strlen and memcpy. __pa(x) is already defined in page.h
> We don't have (and need) defines for error values and consuming sclp
> irqs is not required, as we won't be passing control to some other OS.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> lib/s390x/sclp-ascii.c | 28 +++++++---------------------
> lib/s390x/sclp.h | 2 --
> s390x/Makefile | 1 +
> 3 files changed, 8 insertions(+), 23 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-05-22 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 8:56 [kvm-unit-tests PATCH v3 0/7] s390x: basic test infrastructure David Hildenbrand
2017-05-22 8:56 ` [kvm-unit-tests PATCH v3 1/7] s390x: initial infrastructure David Hildenbrand
2017-05-22 8:56 ` [kvm-unit-tests PATCH v3 2/7] s390x: basic self test David Hildenbrand
2017-05-22 9:39 ` Thomas Huth
2017-05-22 8:56 ` [kvm-unit-tests PATCH v3 3/7] s390x: copy sclp.h and sclp-ascii.c from QEMU David Hildenbrand
2017-05-22 9:45 ` Thomas Huth
2017-05-22 8:56 ` [kvm-unit-tests PATCH v3 4/7] s390x: compile sclp-ascii.c David Hildenbrand
2017-05-22 9:47 ` Thomas Huth [this message]
2017-05-22 8:57 ` [kvm-unit-tests PATCH v3 5/7] s390x: wire up sclp console output David Hildenbrand
2017-05-22 8:57 ` [kvm-unit-tests PATCH v3 6/7] .travis.yml: add s390x David Hildenbrand
2017-05-22 8:57 ` [kvm-unit-tests PATCH v3 7/7] MAINTAINERS: add s390x maintainers David Hildenbrand
2017-05-25 16:37 ` [kvm-unit-tests PATCH v3 0/7] s390x: basic test infrastructure Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78138122-02c8-6744-4dcf-9ff7ba8e3b30@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.