Re: [ndctl PATCH 11/11] cxl/test: Checkout region setup/teardown

From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "Schofield, Alison" <alison.schofield@intel.com>,
	"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
	"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Subject: Re: [ndctl PATCH 11/11] cxl/test: Checkout region setup/teardown
Date: Wed, 13 Jul 2022 15:15:13 +0000	[thread overview]
Message-ID: <78497219caf627714d2ee1b553ff3f78474508eb.camel@intel.com> (raw)
In-Reply-To: <62cedb1ad2457_6070c29451@dwillia2-xfh.jf.intel.com.notmuch>

On Wed, 2022-07-13 at 07:47 -0700, Dan Williams wrote:
> Verma, Vishal L wrote:
> > On Tue, 2022-07-12 at 12:08 -0700, Dan Williams wrote:
> > > Exercise the fundamental region provisioning sysfs mechanisms of discovering
> > > available DPA capacity, allocating DPA to a region, and programming HDM
> > > decoders.
> > > 
> > > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > > ---
> > >  test/cxl-region-create.sh |  122 +++++++++++++++++++++++++++++++++++++++++++++
> > >  test/meson.build          |    2 +
> > >  2 files changed, 124 insertions(+)
> > >  create mode 100644 test/cxl-region-create.sh
> > 
> > Since this isn't actually creating a region, should this be named
> > cxl-reserve-dpa.sh ?
> 
> The test goes all the way to the point of registering a new region with
> libnvdimm, so it is region creation.
> 
> > Alternatively - I guess this test could just be extended to do actual
> > region creation once that is available in cxl-cli?
> 
> I was thinking that's a separate test that moves from just one hardcoded
> pmem region via sysfs toggling to permuting all the possible cxl_test
> region configurations across both modes via 'cxl create-region'. One is
> a sysfs smoke test the other is a create-region unit test.

Ah okay makes sense - maybe this should be called cxl-region-sysfs to
reflect that?
>