Re: [PATCH net] rxrpc: fix some null-ptr-deref bugs in server_key.c

From: Paolo Abeni <pabeni@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org,
	Xiaolong Huang <butterflyhuangxx@gmail.com>,
	Marc Dionne <marc.dionne@auristor.com>,
	linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: fix some null-ptr-deref bugs in server_key.c
Date: Thu, 31 Mar 2022 15:20:24 +0200	[thread overview]
Message-ID: <78917523440153533f0b5aad533a96d0f7c27916.camel@redhat.com> (raw)
In-Reply-To: <3114597.1648729013@warthog.procyon.org.uk>

On Thu, 2022-03-31 at 13:16 +0100, David Howells wrote:
> Paolo Abeni <pabeni@redhat.com> wrote:
> 
> > It looks like we can add a couple of fixes tag to help stable teams:
> > 
> > Fixes: d5953f6543b5 ("rxrpc: Allow security classes to give more info on server keys")
> 
> Not this one.  This includes a check for the one op it adds:
> 
> 	+       if (sec && sec->describe_server_key)
> 	+               sec->describe_server_key(key, m);
> 
> 
> > Fixes: 12da59fcab5a ("xrpc: Hand server key parsing off to the security class")
> 
> There's a missing 'r' in "rxrpc:" in the patch subject, but otherwise this one
> looks like the right one.

Thank you for double-checking. No need to repost, I'll add the tag
while applying it.

Cheeers,

Paolo