From: Trond Myklebust <trondmy@hammerspace.com>
To: "timo@rothenpieler.org" <timo@rothenpieler.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default
Date: Tue, 23 Feb 2021 15:02:40 +0000 [thread overview]
Message-ID: <789e6d842892d9f452095589188b00ea54b94613.camel@hammerspace.com> (raw)
In-Reply-To: <4a53c37a-89bd-d7e7-9597-4117825b4a19@rothenpieler.org>
On Tue, 2021-02-23 at 15:54 +0100, Timo Rothenpieler wrote:
> On 23.02.2021 15:51, Trond Myklebust wrote:
> > On Tue, 2021-02-23 at 15:19 +0100, Timo Rothenpieler wrote:
> > > This follows what was done in
> > > 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13.
> > > With the default being m, it's impossible to build the module
> > > into
> > > the
> > > kernel.
> > >
> > > Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
> > > ---
> > > fs/nfs/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> > > index e2a488d403a6..14a72224b657 100644
> > > --- a/fs/nfs/Kconfig
> > > +++ b/fs/nfs/Kconfig
> > > @@ -127,7 +127,7 @@ config PNFS_BLOCK
> > > config PNFS_FLEXFILE_LAYOUT
> > > tristate
> > > depends on NFS_V4_1 && NFS_V3
> > > - default m
> > > + default NFS_V4
> > >
> >
> > Let's just make that
> >
> > default y
> >
> > ...and let the dependencies work out whether or not this needs to
> > be a
> > 'y', 'm' or 'N'. Tying it to NFS_V4 just makes the Kconfig harder
> > to
> > read, with the result being the same anyway.
>
> Sure. Should I change the other two PNFS_ configs to default to y as
> well while at it?
>
Oh hang on... Brain fart... I thought the dependency on NFS_V4_1 would
suffice to make the correct choice, but it looks like that is a 'bool'
and so it won't propagate the 'm' choice from NFS_V4. That is probably
why Christoph did the NFS_V4 default.
Never mind, then. Let's keep your first patch.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
next prev parent reply other threads:[~2021-02-23 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 14:19 [PATCH] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default Timo Rothenpieler
2021-02-23 14:51 ` Trond Myklebust
2021-02-23 14:54 ` Timo Rothenpieler
2021-02-23 15:02 ` Trond Myklebust [this message]
2021-03-16 22:25 ` Nathan Chancellor
2021-03-17 4:43 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=789e6d842892d9f452095589188b00ea54b94613.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=linux-nfs@vger.kernel.org \
--cc=timo@rothenpieler.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.