From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH 03/23] tests/docker: use project specific container registries
Date: Wed, 13 Jan 2021 18:17:54 -0300 [thread overview]
Message-ID: <78c33963-83d0-4238-bbf3-cbc47d9adefc@redhat.com> (raw)
In-Reply-To: <20201201171825.2243775-4-berrange@redhat.com>
Hi,
On 12/1/20 2:18 PM, Daniel P. Berrangé wrote:
> Since Docker Hub has started to enforce pull rate limits on clients, it
> is preferrable to use project specific container registries where they
> are available. Both Fedora and CentOS provide such registries.
>
> The images in these registries are also refreshed on a more regular
> basis than the ones in docker hub, so the package update should
> generally be faster.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/docker/dockerfiles/centos7.docker | 2 +-
> tests/docker/dockerfiles/centos8.docker | 2 +-
> tests/docker/dockerfiles/fedora-cris-cross.docker | 2 +-
> tests/docker/dockerfiles/fedora-i386-cross.docker | 2 +-
> tests/docker/dockerfiles/fedora-win32-cross.docker | 2 +-
> tests/docker/dockerfiles/fedora-win64-cross.docker | 2 +-
> tests/docker/dockerfiles/fedora.docker | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
I didn't find in Fedora's containers documents [1] if they have a policy
on how long to retain old images (e.g. versions which reached EOL), and
I didn't check CentOS's. Other than that,
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
[1] https://docs.fedoraproject.org/en-US/containers/
>
> diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker
> index d47c96135c..35445becb8 100644
> --- a/tests/docker/dockerfiles/centos7.docker
> +++ b/tests/docker/dockerfiles/centos7.docker
> @@ -1,4 +1,4 @@
> -FROM centos:7
> +FROM registry.centos.org/centos:7
> RUN yum install -y epel-release centos-release-xen-48
>
> RUN yum -y update
> diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
> index bbd82421db..9560bb06e2 100644
> --- a/tests/docker/dockerfiles/centos8.docker
> +++ b/tests/docker/dockerfiles/centos8.docker
> @@ -1,4 +1,4 @@
> -FROM centos:8.1.1911
> +FROM registry.centos.org/centos:8
>
> RUN dnf -y update
> ENV PACKAGES \
> diff --git a/tests/docker/dockerfiles/fedora-cris-cross.docker b/tests/docker/dockerfiles/fedora-cris-cross.docker
> index 09e7e449f9..b7f02d18d3 100644
> --- a/tests/docker/dockerfiles/fedora-cris-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-cris-cross.docker
> @@ -2,7 +2,7 @@
> # Cross compiler for cris system tests
> #
>
> -FROM fedora:30
> +FROM registry.fedoraproject.org/fedora:30
> ENV PACKAGES gcc-cris-linux-gnu
> RUN dnf install -y $PACKAGES
> RUN rpm -q $PACKAGES | sort > /packages.txt
> diff --git a/tests/docker/dockerfiles/fedora-i386-cross.docker b/tests/docker/dockerfiles/fedora-i386-cross.docker
> index cd16cd1bfa..d10586c79e 100644
> --- a/tests/docker/dockerfiles/fedora-i386-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-i386-cross.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:30
> +FROM registry.fedoraproject.org/fedora:30
> ENV PACKAGES \
> gcc \
> glib2-devel.i686 \
> diff --git a/tests/docker/dockerfiles/fedora-win32-cross.docker b/tests/docker/dockerfiles/fedora-win32-cross.docker
> index 087df598a0..8dc4f0d4c9 100644
> --- a/tests/docker/dockerfiles/fedora-win32-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-win32-cross.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:32
> +FROM registry.fedoraproject.org/fedora:32
>
> # Please keep this list sorted alphabetically
> ENV PACKAGES \
> diff --git a/tests/docker/dockerfiles/fedora-win64-cross.docker b/tests/docker/dockerfiles/fedora-win64-cross.docker
> index d5d2f5f00d..c530e6ba36 100644
> --- a/tests/docker/dockerfiles/fedora-win64-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-win64-cross.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:32
> +FROM registry.fedoraproject.org/fedora:32
>
> # Please keep this list sorted alphabetically
> ENV PACKAGES \
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 19e7a3d28a..0bc66f7293 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:32
> +FROM registry.fedoraproject.org/fedora:32
>
> # Please keep this list sorted alphabetically
> ENV PACKAGES \
next prev parent reply other threads:[~2021-01-13 21:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 17:18 [PATCH 00/23] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 01/23] hw/usb/ccid: remove references to NSS Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 02/23] tests/docker: don't use BUILDKIT in GitLab either Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 03/23] tests/docker: use project specific container registries Daniel P. Berrangé
2020-12-02 11:54 ` Gerd Hoffmann
2020-12-02 12:03 ` Daniel P. Berrangé
2021-01-13 21:17 ` Wainer dos Santos Moschetta [this message]
2020-12-01 17:18 ` [PATCH 04/23] tests/docker: use explicit docker.io registry Daniel P. Berrangé
2020-12-01 17:34 ` Philippe Mathieu-Daudé
2021-01-13 21:22 ` Wainer dos Santos Moschetta
2020-12-01 17:18 ` [PATCH 05/23] tests/docker: remove travis container Daniel P. Berrangé
2020-12-02 12:08 ` Thomas Huth
2021-01-13 21:26 ` Wainer dos Santos Moschetta
2020-12-01 17:18 ` [PATCH 06/23] tests/docker: remove FEATURES env var from templates Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 07/23] tests/docker: fix sorting in package lists Daniel P. Berrangé
2020-12-01 17:35 ` Philippe Mathieu-Daudé
2020-12-01 17:18 ` [PATCH 08/23] tests/docker: fix mistakes in centos " Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 09/23] tests/docker: fix mistakes in fedora package list Daniel P. Berrangé
2020-12-01 17:36 ` Philippe Mathieu-Daudé
2020-12-01 17:18 ` [PATCH 10/23] tests/docker: fix mistakes in ubuntu package lists Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 11/23] tests/docker: remove mingw packages from Fedora Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 12/23] tests/docker: add script for automating container refresh Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 13/23] tests/docker: expand centos7 package list Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 14/23] tests/docker: expand centos8 " Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 15/23] tests/docker: expand fedora " Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 16/23] tests/docker: expand ubuntu1804 " Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 17/23] tests/docker: expand ubuntu2004 " Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 18/23] tests/docker: auto-generate centos7 with lcitool Daniel P. Berrangé
2020-12-02 12:07 ` Gerd Hoffmann
2020-12-04 13:37 ` Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 19/23] tests/docker: auto-generate centos8 " Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 20/23] tests/docker: auto-generate fedora " Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 21/23] tests/docker: auto-generate ubuntu1804 " Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 22/23] tests/docker: auto-generate ubuntu2004 " Daniel P. Berrangé
2020-12-01 17:18 ` [PATCH 23/23] tests/docker: remove ubuntu container Daniel P. Berrangé
2020-12-01 17:53 ` [PATCH 00/23] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78c33963-83d0-4238-bbf3-cbc47d9adefc@redhat.com \
--to=wainersm@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=fam@euphon.net \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.