From: Florian Fainelli <f.fainelli@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>, netdev@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Heiner Kallweit <hkallweit1@gmail.com>,
Michal Kubiak <michal.kubiak@intel.com>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] ravb: avoid PHY being resumed when interface is not up
Date: Thu, 16 Mar 2023 13:01:47 -0700 [thread overview]
Message-ID: <78e0a047-ad0a-2ca6-10f7-9734a191cefd@gmail.com> (raw)
In-Reply-To: <20230315074115.3008-2-wsa+renesas@sang-engineering.com>
On 3/15/23 00:41, Wolfram Sang wrote:
> RAVB doesn't need mdiobus suspend/resume, that's why it sets
> 'mac_managed_pm'. However, setting it needs to be moved from init to
> probe, so mdiobus PM functions will really never be called (e.g. when
> the interface is not up yet during suspend/resume).
>
> Fixes: 4924c0cdce75 ("net: ravb: Fix PHY state warning splat during system resume")
> Suggested-by: Heiner Kallweit <hkallweit1@gmail.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
This is a pattern that a lot of drivers have, for better or for worse,
it would be neat if we couldcome up with a common helper that could work
mostly with OF configurations, what do you think?
--
Florian
next prev parent reply other threads:[~2023-03-16 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 7:41 [PATCH net v2 0/2] net: renesas: set 'mac_managed_pm' at probe time Wolfram Sang
2023-03-15 7:41 ` [PATCH net v2 1/2] ravb: avoid PHY being resumed when interface is not up Wolfram Sang
2023-03-16 19:56 ` Sergey Shtylyov
2023-03-16 20:01 ` Florian Fainelli [this message]
2023-03-16 20:06 ` Wolfram Sang
2023-03-16 20:07 ` Florian Fainelli
2023-03-15 7:41 ` [PATCH net v2 2/2] sh_eth: " Wolfram Sang
2023-03-16 19:58 ` Sergey Shtylyov
2023-03-17 0:30 ` [PATCH net v2 0/2] net: renesas: set 'mac_managed_pm' at probe time patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78e0a047-ad0a-2ca6-10f7-9734a191cefd@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.