All of lore.kernel.org
 help / color / mirror / Atom feed
From: Asutosh Das <quic_asutoshd@quicinc.com>
To: <quic_cang@quicinc.com>, <martin.petersen@oracle.com>,
	<linux-scsi@vger.kernel.org>
Cc: <quic_nguyenb@quicinc.com>, <quic_xiaosenh@quicinc.com>,
	<stanley.chu@mediatek.com>, <eddie.huang@mediatek.com>,
	<daejun7.park@samsung.com>, <bvanassche@acm.org>,
	<avri.altman@wdc.com>, <mani@kernel.org>, <beanhuo@micron.com>,
	Asutosh Das <quic_asutoshd@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Jinyoung Choi <j-young.choi@samsung.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH v9 03/16] ufs: core: Introduce Multi-circular queue capability
Date: Wed, 30 Nov 2022 15:50:35 -0800	[thread overview]
Message-ID: <796a65f6f1a6e2d276b05fd76df27ad77c3c38cc.1669850856.git.quic_asutoshd@quicinc.com> (raw)
In-Reply-To: <cover.1669850856.git.quic_asutoshd@quicinc.com>

Add support to check for MCQ capability in the UFSHC.
Add a module parameter to disable MCQ if needed.

Co-developed-by: Can Guo <quic_cang@quicinc.com>
Signed-off-by: Can Guo <quic_cang@quicinc.com>
Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
---
 drivers/ufs/core/ufshcd.c | 26 ++++++++++++++++++++++++++
 include/ufs/ufshcd.h      |  2 ++
 2 files changed, 28 insertions(+)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 595fd3c..eca15b0 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -89,6 +89,28 @@
 /* Polling time to wait for fDeviceInit */
 #define FDEVICEINIT_COMPL_TIMEOUT 1500 /* millisecs */
 
+/* UFSHC 4.0 compliant HC support this mode, refer param_set_mcq_mode() */
+static bool use_mcq_mode = true;
+
+static int param_set_mcq_mode(const char *val, const struct kernel_param *kp)
+{
+	int ret;
+
+	ret = param_set_bool(val, kp);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static const struct kernel_param_ops mcq_mode_ops = {
+	.set = param_set_mcq_mode,
+	.get = param_get_bool,
+};
+
+module_param_cb(use_mcq_mode, &mcq_mode_ops, &use_mcq_mode, 0644);
+MODULE_PARM_DESC(use_mcq_mode, "Control MCQ mode for controllers starting from UFSHCI 4.0. 1 - enable MCQ, 0 - disable MCQ. MCQ is enabled by default");
+
 #define ufshcd_toggle_vreg(_dev, _vreg, _on)				\
 	({                                                              \
 		int _ret;                                               \
@@ -2258,6 +2280,10 @@ static inline int ufshcd_hba_capabilities(struct ufs_hba *hba)
 	if (err)
 		dev_err(hba->dev, "crypto setup failed\n");
 
+	hba->mcq_sup = FIELD_GET(MASK_MCQ_SUPPORT, hba->capabilities);
+	if (!hba->mcq_sup)
+		return err;
+
 	hba->mcq_capabilities = ufshcd_readl(hba, REG_MCQCAP);
 	hba->ext_iid_sup = FIELD_GET(MASK_EXT_IID_SUPPORT,
 				     hba->mcq_capabilities);
diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index aec37cb9..70c0f9f 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -832,6 +832,7 @@ struct ufs_hba_monitor {
  * @complete_put: whether or not to call ufshcd_rpm_put() from inside
  *	ufshcd_resume_complete()
  * @ext_iid_sup: is EXT_IID is supported by UFSHC
+ * @mcq_sup: is mcq supported by UFSHC
  */
 struct ufs_hba {
 	void __iomem *mmio_base;
@@ -982,6 +983,7 @@ struct ufs_hba {
 	u32 luns_avail;
 	bool complete_put;
 	bool ext_iid_sup;
+	bool mcq_sup;
 };
 
 /* Returns true if clocks can be gated. Otherwise false */
-- 
2.7.4


  parent reply	other threads:[~2022-12-01  0:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 23:50 [PATCH v9 00/16] Add Multi Circular Queue Support Asutosh Das
2022-11-30 23:50 ` [PATCH v9 01/16] ufs: core: Optimize duplicate code to read extended feature Asutosh Das
2022-12-01  0:45   ` Stanley Chu
2022-11-30 23:50 ` [PATCH v9 02/16] ufs: core: Probe for ext_iid support Asutosh Das
2022-12-01  0:46   ` Stanley Chu
2022-11-30 23:50 ` Asutosh Das [this message]
2022-12-05  0:58   ` [PATCH v9 03/16] ufs: core: Introduce Multi-circular queue capability Stanley Chu
2022-11-30 23:50 ` [PATCH v9 04/16] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-11-30 23:50 ` [PATCH v9 05/16] ufs: core: mcq: Add support to allocate multiple queues Asutosh Das
2022-11-30 23:50 ` [PATCH v9 06/16] ufs: core: mcq: Configure resource regions Asutosh Das
2022-11-30 23:50 ` [PATCH v9 07/16] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-11-30 23:50 ` [PATCH v9 08/16] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-11-30 23:50 ` [PATCH v9 09/16] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-11-30 23:50 ` [PATCH v9 10/16] ufs: core: mcq: Use shared tags for MCQ mode Asutosh Das
2022-11-30 23:50 ` [PATCH v9 11/16] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-11-30 23:50 ` [PATCH v9 12/16] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-11-30 23:50 ` [PATCH v9 13/16] ufs: core: Prepare for completion in mcq Asutosh Das
2022-11-30 23:50 ` [PATCH v9 14/16] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-12-05 21:24   ` kernel test robot
2022-11-30 23:50 ` [PATCH v9 15/16] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-11-30 23:50 ` [PATCH v9 16/16] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=796a65f6f1a6e2d276b05fd76df27ad77c3c38cc.1669850856.git.quic_asutoshd@quicinc.com \
    --to=quic_asutoshd@quicinc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=daejun7.park@samsung.com \
    --cc=eddie.huang@mediatek.com \
    --cc=j-young.choi@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_xiaosenh@quicinc.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.