From: Li GuiFu via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Gao Xiang <hsiangkao@aol.com>, linux-erofs@lists.ozlabs.org
Cc: Guo Weichao <guoweichao@oppo.com>
Subject: Re: [PATCH v4 3/3] erofs-utils: fuse: add compressed file support
Date: Sat, 5 Dec 2020 16:42:36 +0800 [thread overview]
Message-ID: <798ecfbd-e5a7-0688-0189-55b296c56e78@aliyun.com> (raw)
In-Reply-To: <20201127122409.7035-1-hsiangkao@aol.com>
On 2020/11/27 20:24, Gao Xiang via Linux-erofs wrote:
> From: Huang Jianan <huangjianan@oppo.com>
>
> This patch adds a simple approach (~ 700 LOC) to EROFS fixed-sized
> output decompression without inplace I/O or decompression inplace
> so it's easy to be ported everywhere with less constraint.
>
> However, the on-disk compressed index parser (aka. zmap) is largely
> kept in line with the kernel side, therefore new on-disk features
> under development can be verified effectively first here.
>
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> Signed-off-by: Guo Weichao <guoweichao@oppo.com>
> Signed-off-by: Gao Xiang <hsiangkao@aol.com>
> ---
> changes since v3:
> - fix build error without lz4 library.
>
> include/erofs/decompress.h | 35 ++++
> include/erofs/defs.h | 5 +
> include/erofs/internal.h | 8 +
> lib/Makefile.am | 2 +-
> lib/data.c | 72 ++++++-
> lib/decompress.c | 87 ++++++++
> lib/namei.c | 4 +
> lib/zmap.c | 415 +++++++++++++++++++++++++++++++++++++
> 8 files changed, 626 insertions(+), 2 deletions(-)
> create mode 100644 include/erofs/decompress.h
> create mode 100644 lib/decompress.c
> create mode 100644 lib/zmap.c
>
It looks good
Reviewed-by: Li Guifu <bluce.lee@aliyun.com>
Tested-by: Li Guifu <bluce.lee@aliyun.com>
Thanks,
next prev parent reply other threads:[~2020-12-05 8:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201127114617.13055-1-hsiangkao.ref@aol.com>
2020-11-27 11:46 ` [PATCH v3 0/3] erofs-utils: introduce fuse implementation Gao Xiang via Linux-erofs
2020-11-27 11:46 ` [PATCH v3 1/3] " Gao Xiang via Linux-erofs
2020-11-27 12:19 ` [PATCH v4 " Gao Xiang via Linux-erofs
2020-11-27 11:46 ` [PATCH v3 2/3] erofs-utils: fuse: support symlink & special inode Gao Xiang via Linux-erofs
2020-12-05 8:42 ` Li GuiFu via Linux-erofs
2020-12-05 8:54 ` Gao Xiang
2020-11-27 11:46 ` [PATCH v3 3/3] erofs-utils: fuse: add compressed file support Gao Xiang via Linux-erofs
2020-11-27 12:24 ` [PATCH v4 " Gao Xiang via Linux-erofs
2020-12-05 8:42 ` Li GuiFu via Linux-erofs [this message]
2020-11-27 13:16 ` [PATCH v3 0/3] erofs-utils: introduce fuse implementation Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=798ecfbd-e5a7-0688-0189-55b296c56e78@aliyun.com \
--to=linux-erofs@lists.ozlabs.org \
--cc=bluce.lee@aliyun.com \
--cc=guoweichao@oppo.com \
--cc=hsiangkao@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.