From: Maximilian Luz <luzmaximilian@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Platform Driver" <platform-driver-x86@vger.kernel.org>,
"Darren Hart" <dvhart@infradead.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Gross" <mgross@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Gayatri Kammela" <gayatri.kammela@intel.com>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"Blaž Hrastnik" <blaz@mxxn.io>,
"Stephen Just" <stephenjust@gmail.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Chen Yu" <yu.c.chen@intel.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] platform/surface: Move Surface 3 WMI driver to platform/surface
Date: Thu, 8 Oct 2020 17:21:03 +0200 [thread overview]
Message-ID: <79cf1a3a-93e1-5f34-27ae-9fea31a99df7@gmail.com> (raw)
In-Reply-To: <CAHp75VfPaGqb=yCpi_2f8SNzrj+0pd-r5VqAEgRgMCiJJB6D0w@mail.gmail.com>
On 10/8/20 4:54 PM, Andy Shevchenko wrote:
> On Thu, Oct 8, 2020 at 5:35 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>>
>> Move the Surface 3 WMI driver from platform/x86 to the newly created
>> platform/surface directory.
>
>> -# place Microsoft Surface platform drivers here
>
>> -# place Microsoft Surface platform drivers here
>
> Not sure if we need these comments in the first place.
I thought it might look a bit weird having the "if" directly followed by
"endif" without at least a comment in between. I'll remove them if you
prefer that.
Thanks,
Max
next prev parent reply other threads:[~2020-10-08 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 14:34 [PATCH v3 0/5] platform/surface: Create a platform subdirectory for Microsoft Surface devices Maximilian Luz
2020-10-08 14:34 ` [PATCH v3 1/5] platform: Add Surface platform directory Maximilian Luz
2020-10-08 14:52 ` Andy Shevchenko
2020-10-08 15:18 ` Maximilian Luz
2020-10-08 19:43 ` Hans de Goede
2020-10-08 14:34 ` [PATCH v3 2/5] platform/surface: Move Surface 3 WMI driver to platform/surface Maximilian Luz
2020-10-08 14:54 ` Andy Shevchenko
2020-10-08 15:21 ` Maximilian Luz [this message]
2020-10-08 14:34 ` [PATCH v3 3/5] platform/surface: Move Surface 3 Button " Maximilian Luz
2020-10-08 14:34 ` [PATCH v3 4/5] platform/surface: Move Surface 3 Power OpRegion " Maximilian Luz
2020-10-08 14:34 ` [PATCH v3 5/5] platform/surface: Move Surface Pro 3 Button " Maximilian Luz
2020-10-09 5:30 ` Chen Yu
2020-10-08 14:56 ` [PATCH v3 0/5] platform/surface: Create a platform subdirectory for Microsoft Surface devices Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79cf1a3a-93e1-5f34-27ae-9fea31a99df7@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=blaz@mxxn.io \
--cc=dan.carpenter@oracle.com \
--cc=dvhart@infradead.org \
--cc=enric.balletbo@collabora.com \
--cc=gayatri.kammela@intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stephenjust@gmail.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.