All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ospan, Abylay" <aospan@amazon.com>
To: "Stephan Müller" <smueller@chronox.de>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: RE: [PATCH 0/3] crypto: jitter - Offer compile-time options
Date: Mon, 25 Sep 2023 15:11:11 +0000	[thread overview]
Message-ID: <79fe855f99e44c97b6ac3348faac05d3@amazon.com> (raw)
In-Reply-To: <2700818.mvXUDI8C0e@positron.chronox.de>

Hi Stephan,

We ran tests with your patches on our bare metal platform (AMD Epyc CPU) and saw an improvement in boot time entropy after analyzing the collected jitter deltas.
Patches looks good to me.
Thanks for your work!

Acked-by: Abylay Ospan <aospan@amazon.com>

-----Original Message-----
From: Stephan Müller <smueller@chronox.de> 
Sent: Thursday, September 21, 2023 7:48 AM
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org; Ospan, Abylay <aospan@amazon.com>
Subject: [EXTERNAL] [PATCH 0/3] crypto: jitter - Offer compile-time options

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



Hi,

the following patchset offers a set of compile-time options to accommodate different hardware with different entropy rates implied in their timers. This allows configuring the Jitter RNG in systems which exhibits insufficient entropy with the default parameters. The default parameters defined by the patches, however, are identical to the existing code and thus do not alter the Jitter RNG behavior.

The first patch sets the state by allowing the configuration of different oversampling rates. The second patch allows the configuration of different memory sizes and the third allows the configuration of differnet oversampling rates.

The update of the power up test with the first patch also addresses reports that the Jitter RNG did not initialize due to it detected insufficient entropy.

Stephan Mueller (3):
  crypto: jitter - add RCT/APT support for different OSRs
  crypto: jitter - Allow configuration of memory size
  crypto: jitter - Allow configuration of oversampling rate

 crypto/Kconfig               |  60 +++++++++
 crypto/jitterentropy-kcapi.c |  17 ++-
 crypto/jitterentropy.c       | 249 ++++++++++++++++++-----------------
 crypto/jitterentropy.h       |   5 +-
 4 files changed, 207 insertions(+), 124 deletions(-)

--
2.42.0





  parent reply	other threads:[~2023-09-25 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 11:47 [PATCH 0/3] crypto: jitter - Offer compile-time options Stephan Müller
2023-09-21 11:48 ` [PATCH 1/3] crypto: jitter - add RCT/APT support for different OSRs Stephan Müller
2023-09-21 11:48 ` [PATCH 2/3] crypto: jitter - Allow configuration of memory size Stephan Müller
2023-09-21 11:48 ` [PATCH 3/3] crypto: jitter - Allow configuration of oversampling rate Stephan Müller
2023-09-25 15:11 ` Ospan, Abylay [this message]
2023-10-01  8:34 ` [PATCH 0/3] crypto: jitter - Offer compile-time options Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79fe855f99e44c97b6ac3348faac05d3@amazon.com \
    --to=aospan@amazon.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.