From: Paolo Valente <paolo.valente@linaro.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 2/3] bfq: Use 'ttime' local variable
Date: Thu, 11 Jun 2020 09:14:38 +0200 [thread overview]
Message-ID: <7ADC14C0-9252-4C6C-9D32-2AAFD45FDF22@linaro.org> (raw)
In-Reply-To: <20200605141629.15347-2-jack@suse.cz>
> Il giorno 5 giu 2020, alle ore 16:16, Jan Kara <jack@suse.cz> ha scritto:
>
> Use local variable 'ttime' instead of dereferencing bfqq.
>
Acked-by: Paolo Valente <paolo.valente@linaro.org>
Thanks!
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> block/bfq-iosched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 50017275915f..c66c3eaa9e26 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -5196,7 +5196,7 @@ static void bfq_update_io_thinktime(struct bfq_data *bfqd,
>
> elapsed = min_t(u64, elapsed, 2ULL * bfqd->bfq_slice_idle);
>
> - ttime->ttime_samples = (7*bfqq->ttime.ttime_samples + 256) / 8;
> + ttime->ttime_samples = (7*ttime->ttime_samples + 256) / 8;
> ttime->ttime_total = div_u64(7*ttime->ttime_total + 256*elapsed, 8);
> ttime->ttime_mean = div64_ul(ttime->ttime_total + 128,
> ttime->ttime_samples);
> --
> 2.16.4
>
next prev parent reply other threads:[~2020-06-11 7:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 14:16 [PATCH 0/3] bfq: Two fixes and a cleanup for sequential readers Jan Kara
2021-01-13 10:09 ` [PATCH 0/3 v2] " Jan Kara
2020-06-05 14:16 ` [PATCH 1/3] bfq: Avoid false bfq queue merging Jan Kara
2020-06-11 7:13 ` Paolo Valente
2020-06-11 8:31 ` Jan Kara
2020-06-11 14:12 ` Paolo Valente
2021-01-10 9:21 ` Paolo Valente
2020-06-05 14:16 ` [PATCH 2/3] bfq: Use 'ttime' local variable Jan Kara
2020-06-11 7:14 ` Paolo Valente [this message]
2020-06-05 14:16 ` [PATCH 3/3] bfq: Use only idle IO periods for think time calculations Jan Kara
2020-06-11 14:11 ` Paolo Valente
2020-06-11 14:39 ` Jan Kara
2020-07-22 9:13 ` Paolo Valente
2020-07-27 7:35 ` Jan Kara
2020-08-26 13:54 ` Jan Kara
2020-09-02 15:17 ` Jan Kara
2021-01-10 9:23 ` Paolo Valente
2021-01-13 9:56 ` Jan Kara
2021-01-13 10:09 ` [PATCH 1/3] bfq: Avoid false bfq queue merging Jan Kara
2021-01-13 10:09 ` [PATCH 2/3] bfq: Use 'ttime' local variable Jan Kara
2021-01-13 10:09 ` [PATCH 3/3] bfq: Use only idle IO periods for think time calculations Jan Kara
2021-01-27 15:27 ` [PATCH 0/3 v2] bfq: Two fixes and a cleanup for sequential readers Jan Kara
2021-01-27 16:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ADC14C0-9252-4C6C-9D32-2AAFD45FDF22@linaro.org \
--to=paolo.valente@linaro.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.