From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Alexandre Mergnat <amergnat@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Qii Wang <qii.wang@mediatek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-i2c@vger.kernel.org, Rob Herring <robh@kernel.org>,
Fabien Parent <fparent@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] i2c: i2c-mt65xx: add MT8365 SoC support
Date: Tue, 17 Jan 2023 13:49:44 +0100 [thread overview]
Message-ID: <7a6522ef-7cf7-808f-8be4-07cf5567d18a@collabora.com> (raw)
In-Reply-To: <20221122-mt8365-i2c-support-v1-4-4aeb7c54c67b@baylibre.com>
Il 17/01/23 09:49, Alexandre Mergnat ha scritto:
> From: Fabien Parent <fparent@baylibre.com>
>
> Add support for I2C on MT8365 SoCs.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index d80e59340d97..2c9dbb42861a 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -511,6 +511,19 @@ static const struct mtk_i2c_compatible mt8192_compat = {
> .max_dma_support = 36,
> };
>
> +static const struct mtk_i2c_compatible mt8365_compat = {
This is exactly the same as mt8168_compat... so you can avoid adding this one
and you can also avoid adding the compatible to this driver.
This means that you can get it working with a devicetree declaring
compatible = "mediatek,mt8365-i2c", "mediatek,mt8168-i2c";
like you're already doing and without any addition to this driver at all.
So, you can drop this commit.
Regards,
Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Alexandre Mergnat <amergnat@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Qii Wang <qii.wang@mediatek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-i2c@vger.kernel.org, Rob Herring <robh@kernel.org>,
Fabien Parent <fparent@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] i2c: i2c-mt65xx: add MT8365 SoC support
Date: Tue, 17 Jan 2023 13:49:44 +0100 [thread overview]
Message-ID: <7a6522ef-7cf7-808f-8be4-07cf5567d18a@collabora.com> (raw)
In-Reply-To: <20221122-mt8365-i2c-support-v1-4-4aeb7c54c67b@baylibre.com>
Il 17/01/23 09:49, Alexandre Mergnat ha scritto:
> From: Fabien Parent <fparent@baylibre.com>
>
> Add support for I2C on MT8365 SoCs.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index d80e59340d97..2c9dbb42861a 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -511,6 +511,19 @@ static const struct mtk_i2c_compatible mt8192_compat = {
> .max_dma_support = 36,
> };
>
> +static const struct mtk_i2c_compatible mt8365_compat = {
This is exactly the same as mt8168_compat... so you can avoid adding this one
and you can also avoid adding the compatible to this driver.
This means that you can get it working with a devicetree declaring
compatible = "mediatek,mt8365-i2c", "mediatek,mt8168-i2c";
like you're already doing and without any addition to this driver at all.
So, you can drop this commit.
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-17 12:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 8:49 [PATCH 0/4] Add MediaTek MT8365 I2C support Alexandre Mergnat
2023-01-17 8:49 ` Alexandre Mergnat
2023-01-17 8:49 ` [PATCH 1/4] dt-bindings: i2c: i2c-mt65xx: add binding for MT8365 SoC Alexandre Mergnat
2023-01-17 8:49 ` Alexandre Mergnat
2023-01-17 12:50 ` AngeloGioacchino Del Regno
2023-01-17 12:50 ` AngeloGioacchino Del Regno
2023-01-17 8:49 ` [PATCH 2/4] arm64: dts: mediatek: add i2c support for mt8365 SoC Alexandre Mergnat
2023-01-17 8:49 ` Alexandre Mergnat
2023-01-17 12:52 ` AngeloGioacchino Del Regno
2023-01-17 12:52 ` AngeloGioacchino Del Regno
2023-01-17 8:49 ` [PATCH 3/4] arm64: dts: mediatek: enable i2c0 for mt8365-evk board Alexandre Mergnat
2023-01-17 8:49 ` Alexandre Mergnat
2023-01-17 8:49 ` [PATCH 4/4] i2c: i2c-mt65xx: add MT8365 SoC support Alexandre Mergnat
2023-01-17 8:49 ` Alexandre Mergnat
2023-01-17 12:49 ` AngeloGioacchino Del Regno [this message]
2023-01-17 12:49 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a6522ef-7cf7-808f-8be4-07cf5567d18a@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=amergnat@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qii.wang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.