Re: [PATCH 09/14] ASoC: amd: add Renoir ACP PCI driver PM ops - Pierre-Louis Bossart

From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Alex Deucher <alexdeucher@gmail.com>,
	alsa-devel@alsa-project.org, broonie@kernel.org,
	vijendar.mukunda@amd.com, tiwai@suse.de
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH 09/14] ASoC: amd: add Renoir ACP PCI driver PM ops
Date: Tue, 5 May 2020 16:48:51 -0500	[thread overview]
Message-ID: <7a675344-e5be-0570-f56e-6def475d19b8@linux.intel.com> (raw)
In-Reply-To: <20200505205327.642282-10-alexander.deucher@amd.com>

> diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/rn-pci-acp3x.c
> index 362409ef0d85..6d013a1bffa6 100644
> --- a/sound/soc/amd/renoir/rn-pci-acp3x.c
> +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c
> @@ -10,6 +10,7 @@
>   #include <linux/delay.h>
>   #include <linux/platform_device.h>
>   #include <linux/interrupt.h>
> +#include <linux/pm_runtime.h>
>   
>   #include "rn_acp3x.h"
>   
> @@ -233,6 +234,12 @@ static int snd_rn_acp_probe(struct pci_dev *pci,
>   		ret = PTR_ERR(adata->pdev);
>   		goto unregister_devs;
>   	}
> +	pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
> +	pm_runtime_use_autosuspend(&pci->dev);
> +	pm_runtime_set_active(&pci->dev);

is the set_active() needed? I haven't seen this in the other PCI audio 
drivers?

> +	pm_runtime_put_noidle(&pci->dev);
> +	pm_runtime_enable(&pci->dev);

same, is the _enable() needed()?

> +	pm_runtime_allow(&pci->dev);
>   	return 0;
>   
>   unregister_devs:
> @@ -250,6 +257,42 @@ static int snd_rn_acp_probe(struct pci_dev *pci,
>   	return ret;
>   }
>   