From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Wei Liu" <wl@xen.org>, "Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Pu Wen" <puwen@hygon.cn>, "Andy Lutomirski" <luto@kernel.org>
Subject: Re: [PATCH v1 1/2] x86/cpuid: Expose NullSelectorClearsBase CPUID bit to guests
Date: Mon, 6 Sep 2021 20:20:34 +0100 [thread overview]
Message-ID: <7a87358a-37b9-0292-b6bd-ef33026426df@citrix.com> (raw)
In-Reply-To: <239f7624f3ac3793993dc045d451079aa555b90d.1630929059.git.jane.malalane@citrix.com>
On 06/09/2021 13:00, Jane Malalane wrote:
> diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h
> index 380b51b1b3..e5a7c94c78 100644
> --- a/xen/include/public/arch-x86/cpufeatureset.h
> +++ b/xen/include/public/arch-x86/cpufeatureset.h
> @@ -285,6 +285,7 @@ XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */
>
> /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */
> XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */
> +XEN_CPUFEATURE(NSCB, 11*32+ 6) /*A Null Selector Clears Base */
On second thoughts, I'm tempted to add " (and limit too)" to the comment.
Can be fixed on commit.
~Andrew
next prev parent reply other threads:[~2021-09-06 19:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 12:00 [PATCH v1 0/2] x86/cpuid: Use AMD's NullSelectorClearsBase CPUID bit Jane Malalane
2021-09-06 12:00 ` [PATCH v1 1/2] x86/cpuid: Expose NullSelectorClearsBase CPUID bit to guests Jane Malalane
2021-09-06 15:04 ` Jan Beulich
2021-09-06 19:20 ` Andrew Cooper [this message]
2021-09-06 12:00 ` [PATCH v1 2/2] x86/cpuid: Detect null segment behaviour on Zen2 CPUs Jane Malalane
2021-09-06 15:17 ` Jan Beulich
2021-09-06 18:07 ` Andrew Cooper
2021-09-07 6:09 ` Jan Beulich
2021-09-07 13:27 ` Andrew Cooper
2021-09-07 14:21 ` Jan Beulich
2021-09-08 8:19 ` [PATCH v2 " Jane Malalane
2021-09-08 12:08 ` Jan Beulich
2021-09-08 12:28 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a87358a-37b9-0292-b6bd-ef33026426df@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jane.malalane@citrix.com \
--cc=jbeulich@suse.com \
--cc=luto@kernel.org \
--cc=puwen@hygon.cn \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.