All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: masonccyang@mxic.com.tw
Cc: bbrezillon@kernel.org, broonie@kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Simon Horman <horms@verge.net.au>,
	juliensu@mxic.com.tw, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-spi@vger.kernel.org,
	marek.vasut@gmail.com, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v7 2/2] dt-bindings: spi: Document Renesas R-Car Gen3 RPC-IF controller bindings
Date: Thu, 24 Jan 2019 11:16:43 +0300	[thread overview]
Message-ID: <7cdecc93-fc7a-3602-25c2-23107dca2a5e@cogentembedded.com> (raw)
In-Reply-To: <OF87800430.BAF731CA-ON4825838C.0006CCEE-4825838C.00092BDE@mxic.com.tw>

On 24.01.2019 4:40, masonccyang@mxic.com.tw wrote:

>  > > @@ -0,0 +1,46 @@
>  > > +Renesas R-Car Gen3 RPC-IF controller Device Tree Bindings
>  > > +--------------------------------------------------------------------
>  > > +
>  > > +Required properties:
>  > > +- compatible: should be an SoC-specific compatible value, followed by
>  > > +      "renesas,rcar-gen3-rpc" as a fallback, i.e.,
>  > > +      "renesas,r8a77995-rpc", "renesas,rcar-gen3-rpc".
>  > > +      "renesas,r8a7795-rpc" (R-Car H3)
>  > > +      "renesas,r8a7796-rpc" (R-Car M3-W)
>  > > +      "renesas,r8a77965-rpc" (R-Car M3-N)
>  > > +      "renesas,r8a77970-rpc" (R-Car V3M)
>  > > +      "renesas,r8a77980-rpc" (R-Car V3H)
>  > > +      "renesas,r8a77990-rpc" (R-Car E3)
>  > > +      "renesas,r8a77995-rpc" (R-Car D3)
>  > > +- reg: should contain three register areas:
>  >
>  >    The driver now handles "dirmap" and "wbuf" resources as optional --
>  > you need to document that.
>  >
> 
> Why ?

    Because the driver treats "dirmap" and "wbuf" as optional resources.

[...]

> best regards,
> Mason

MBR, Sergei

  parent reply	other threads:[~2019-01-24  8:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23  7:09 [PATCH v7 0/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI driver Mason Yang
2019-01-23  7:09 ` [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Mason Yang
2019-01-23 18:04   ` Sergei Shtylyov
     [not found]     ` <OFC86383C3.5347178A-ON4825838C.00093E95-4825838C.000B9D6F@mxic.com.tw>
2019-01-24  9:12       ` Geert Uytterhoeven
2019-01-24 11:27       ` Sergei Shtylyov
2019-01-24 11:27       ` Sergei Shtylyov
2019-01-24  1:51   ` Marek Vasut
     [not found]     ` <OF767ACC95.EECC73BE-ON4825838C.000BD6A3-4825838C.000D23A6@mxic.com.tw>
2019-01-24  3:13       ` Marek Vasut
     [not found]         ` <OF891E176A.614DBEEF-ON4825838C.0022D454-4825838C.002396ED@mxic.com.tw>
2019-01-26  9:41           ` Marek Vasut
     [not found]             ` <OFEAAE10B4.20C3E45D-ON48258390.0007CD37-48258390.0009066E@mxic.com.tw>
2019-01-28 11:03               ` Marek Vasut
     [not found]                 ` <OF1DC7FF88.3574E5B9-ON48258391.000A5001-48258391.000D5DDE@mxic.com.tw>
2019-01-29  4:43                   ` Marek Vasut
     [not found]                     ` <OFA6EF1EB2.198B44D0-ON48258392.00099520-48258392.000D03A4@mxic.com.tw>
2019-01-30  7:15                       ` Marek Vasut
2019-01-30  9:26                         ` Boris Brezillon
2019-01-24 11:31       ` Sergei Shtylyov
2019-01-23  7:09 ` [PATCH v7 2/2] dt-bindings: spi: Document Renesas R-Car Gen3 RPC-IF controller bindings Mason Yang
2019-01-23 18:06   ` Sergei Shtylyov
     [not found]     ` <OF87800430.BAF731CA-ON4825838C.0006CCEE-4825838C.00092BDE@mxic.com.tw>
2019-01-24  8:16       ` Sergei Shtylyov [this message]
2019-01-24  1:53   ` Marek Vasut
     [not found]     ` <OFB904EE00.27B08F2C-ON4825838C.000D6846-4825838C.000E90F7@mxic.com.tw>
2019-01-24  9:06       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cdecc93-fc7a-3602-25c2-23107dca2a5e@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=bbrezillon@kernel.org \
    --cc=broonie@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=juliensu@mxic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=zhengxunli@mxic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.