From: Karsten Graul <kgraul@linux.ibm.com>
To: Dust Li <dust.li@linux.alibaba.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] net/smc: fix wrong list_del in smc_lgr_cleanup_early
Date: Tue, 30 Nov 2021 17:20:19 +0100 [thread overview]
Message-ID: <7d09ae3d-3715-ecf6-08d5-a9606bd4966d@linux.ibm.com> (raw)
In-Reply-To: <20211130151731.55951-1-dust.li@linux.alibaba.com>
On 30/11/2021 16:17, Dust Li wrote:
> smc_lgr_cleanup_early() meant to deleted the link
> group from the link group list, but it deleted
> the list head by mistake.
>
> This may cause memory corruption since we didn't
> remove the real link group from the list and later
> memseted the link group structure.
Great finding, thank you!
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
next prev parent reply other threads:[~2021-11-30 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 15:17 [PATCH net] net/smc: fix wrong list_del in smc_lgr_cleanup_early Dust Li
2021-11-30 16:20 ` Karsten Graul [this message]
2021-11-30 18:07 ` kernel test robot
2021-11-30 18:07 ` kernel test robot
2021-12-01 2:22 ` dust.li
2021-12-01 2:22 ` dust.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d09ae3d-3715-ecf6-08d5-a9606bd4966d@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=guwen@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.