From: Florian Fainelli <f.fainelli@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>,
Peter Robinson <pbrobinson@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] bus: brcmstb_gisb: Depend on SoC specifics over generic arm
Date: Fri, 13 Oct 2023 13:54:49 -0700 [thread overview]
Message-ID: <7d259f98-9470-4d23-976d-6c753176f280@gmail.com> (raw)
In-Reply-To: <0b872a7c-369e-4d55-9cbb-69005037ed1c@app.fastmail.com>
On 10/9/23 07:25, Arnd Bergmann wrote:
> On Mon, Oct 9, 2023, at 15:58, Peter Robinson wrote:
>> Depend on the explicit SoC defines rather than generic
>> architectures like most of the rest of the HW drivers do.
>>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> ---
>> drivers/bus/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
>> index c98dd6ca2629..e6742998f372 100644
>> --- a/drivers/bus/Kconfig
>> +++ b/drivers/bus/Kconfig
>> @@ -31,7 +31,7 @@ config ARM_INTEGRATOR_LM
>>
>> config BRCMSTB_GISB_ARB
>> tristate "Broadcom STB GISB bus arbiter"
>> - depends on ARM || ARM64 || MIPS
>> + depends on ARCH_BRCMSTB || BMIPS_GENERIC
>
> If there are no compile time dependencies, it might be good
> to also add "|| COMPILE_TEST" to the dependency
> and have the drivers built in an x86_64 allmodconfig.
Agreed, I did apply Peter's patch because I think this can be a separate
patch. Thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-13 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 13:58 [PATCH 0/3] Cleanup some BRCMSTB Kconfig options Peter Robinson
2023-10-09 13:58 ` [PATCH 1/3] soc: bcm: brcmstb: depend on ARCH_BRCMSTB over arm arches Peter Robinson
2023-10-09 17:50 ` Florian Fainelli
2023-10-09 13:58 ` [PATCH 2/3] power: reset: brcmstb: Depend on actual SoC dependencies Peter Robinson
2023-10-09 13:58 ` Peter Robinson
2023-10-09 17:58 ` Florian Fainelli
2023-10-09 17:58 ` Florian Fainelli
2023-10-09 13:58 ` [PATCH 3/3] bus: brcmstb_gisb: Depend on SoC specifics over generic arm Peter Robinson
2023-10-09 14:25 ` Arnd Bergmann
2023-10-13 20:54 ` Florian Fainelli [this message]
2023-10-09 17:50 ` Florian Fainelli
2023-10-13 2:03 ` (subset) [PATCH 0/3] Cleanup some BRCMSTB Kconfig options Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d259f98-9470-4d23-976d-6c753176f280@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pbrobinson@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.