From: Josef Bacik <josef@toxicpanda.com>
To: Qu Wenruo <wqu@suse.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: btrfs/022: Disable snapshot ioctl in fsstress
Date: Thu, 6 Feb 2020 19:38:07 -0500 [thread overview]
Message-ID: <7da58abd-eb5e-0a7f-f3bf-205f1daf95cd@toxicpanda.com> (raw)
In-Reply-To: <8199544d-c5cb-eb1e-ed7c-f9b170324997@suse.com>
On 2/6/20 7:35 PM, Qu Wenruo wrote:
>
>
> On 2020/2/6 下午11:47, Josef Bacik wrote:
>> On 2/6/20 12:32 AM, Qu Wenruo wrote:
>>> Since commit fd0830929573 ("fsstress: add the ability to create
>>> snapshots") adds the ability for fsstress to create/delete snapshot and
>>> subvolume, test case btrfs/022 fails as _btrfs_get_subvolid can't
>>> handle multiple subvolumes under the same path.
>>>
>>> So manually disable snapshot/subvolume creation and deletion ioctl in
>>> this
>>> test case. Other qgroup test cases aren't affected.
>>>
>>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>>
>> Why not just fix _btrfs_get_subvolid? You can use egrep to make sure
>> the name matches exactly. Thanks,
>
> Because we have other requirement, like limit tests.
>
> If we have other snapshots/subvolumes, they don't have the same limit,
> thus unable to test qgroup properly.
>
That's fair, but we should also fix _btrfs_get_subvolid since we know it doesn't
work in this case. Thanks,
Josef
next prev parent reply other threads:[~2020-02-07 0:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 5:32 [PATCH] fstests: btrfs/022: Disable snapshot ioctl in fsstress Qu Wenruo
2020-02-06 15:47 ` Josef Bacik
2020-02-07 0:35 ` Qu Wenruo
2020-02-07 0:38 ` Josef Bacik [this message]
2020-02-07 0:38 ` Qu Wenruo
2020-02-07 1:39 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da58abd-eb5e-0a7f-f3bf-205f1daf95cd@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.