Re: [PATCH] pseries: fix migration-test and pxe-test

From: Laurent Vivier <lvivier@redhat.com>
To: quintela@redhat.com
Cc: Thomas Huth <thuth@redhat.com>, Greg Kurz <groug@kaod.org>,
	qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] pseries: fix migration-test and pxe-test
Date: Wed, 20 Nov 2019 15:38:51 +0100	[thread overview]
Message-ID: <7ddc4653-aed5-2cf9-4a7a-5c64fdd0d4b9@redhat.com> (raw)
In-Reply-To: <87imneobvf.fsf@trasno.org>

On 20/11/2019 15:34, Juan Quintela wrote:
> Laurent Vivier <lvivier@redhat.com> wrote:
>> Commit 29cb4187497d ("spapr: Set VSMT to smp_threads by default")
>> has introduced a new default value for VSMT that is not supported
>> by old kernels (before 4.13 kernel) and this breaks "make check"
>> on these kernels.
>>
>> To fix that, explicitly set in the involved tests the value that was
>> used as the default value before the change.
>>
>> Cc: Greg Kurz <groug@kaod.org>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> 
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> 
> A comment telling that never their use could help for future readers
> O:-)

I assumed that "git blame" would be enough for a reader that wants more
details :)

Thanks,
Laurent