Re: [PATCH] docs: sphinx/requirements: Limit jinja2<3.1

From: Akira Yokosawa <akiyks@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>, Jonathan Corbet <corbet@lwn.net>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs: sphinx/requirements: Limit jinja2<3.1
Date: Tue, 29 Mar 2022 23:01:37 +0900	[thread overview]
Message-ID: <7de98030-c154-416c-ef80-17a2fd812dd1@gmail.com> (raw)
In-Reply-To: <02a00556-d885-7532-64ad-14027a4b5e33@gmail.com>

On Tue, 29 Mar 2022 20:01:46 +0700,
Bagas Sanjaya wrote:
> On 29/03/22 13.07, Akira Yokosawa wrote:
>> diff --git a/Documentation/sphinx/requirements.txt b/Documentation/sphinx/requirements.txt
>> index 9a35f50798a6..2c573541ab71 100644
>> --- a/Documentation/sphinx/requirements.txt
>> +++ b/Documentation/sphinx/requirements.txt
>> @@ -1,2 +1,4 @@
>> +# jinja2>=3.1 is not compatible with Sphinx<4.0
>> +jinja2<3.1
>>   sphinx_rtd_theme
>>   Sphinx==2.4.4
>>
> 
> I see that we had already pinned the exact Sphinx version to 2.4.4 (or am
> I read the requirements wrong?), so this only matters when people use Sphinx
> from distribution packages, rather than using virtualenv as recommended.

On the contrary!

This matters when you do fresh-install of Sphinx 2.4.4 using virtualenv.
Please try it without the limit of inja2<3.1.
If you can't reproduce the breakage, I might be missing something
something important.

I guess you had your Sphinx installed before jinja2 3.1.0
was released (March 24, 2022), didn't you?

        Thanks, Akira