From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning
Date: Wed, 31 May 2017 09:52:39 +0100 [thread overview]
Message-ID: <7eb65ba5-2f5c-2d80-1c78-23e3c285f84f@arm.com> (raw)
In-Reply-To: <59230474020000780015BBE3@prv-mh.provo.novell.com>
Hi,
On 05/22/2017 02:32 PM, Jan Beulich wrote:
>>>> On 22.05.17 at 15:12, <andrew.cooper3@citrix.com> wrote:
>> _PAGE_GNTTAB is only used in debug builds of Xen; in release builds, it has
>> the value 0. Coverity complains that "l1e_get_flags(l1e) & 0" is logically
>> dead.
>>
>> Add an extra condition into the logic to skip the flag check if _PAGE_GNTTAB
>> is 0.
>
> And this helps? To me "if ( 0 && ... )" and "if ( (x & 0) && ... )" look
> logically the same (i.e. I'd expect the same warnings to be triggered
> [or not]).
I haven't seen any answer on this question. Andrew, does this patch
still hold for Xen 4.9?
>
>> No functional change.
>>
>> Coverity-ID: 1362036
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> So provided the change really silences Coverity:
> Acked-by: Jan Beulich <jbeulich@suse.com>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-31 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:12 [PATCH for-4.9] x86/mm: Placate DEADCODE Coverity warning Andrew Cooper
2017-05-22 13:32 ` Jan Beulich
2017-05-31 8:52 ` Julien Grall [this message]
2017-05-31 13:23 ` Andrew Cooper
2017-06-01 11:09 ` Julien Grall
2017-06-01 11:15 ` Jan Beulich
2017-06-01 11:18 ` Julien Grall
2017-06-01 11:21 ` Jan Beulich
2017-06-01 17:25 ` Julien Grall
2017-06-01 17:44 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eb65ba5-2f5c-2d80-1c78-23e3c285f84f@arm.com \
--to=julien.grall@arm.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.