Re: [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

From: "Zhang, Xiong Y" <xiong.y.zhang@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function
Date: Fri, 14 Aug 2015 05:18:56 +0000	[thread overview]
Message-ID: <8082FF9BCB2B054996454E47167FF4EC029C2360@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20150812130059.GM17734@phenom.ffwll.local>

> On Mon, Aug 10, 2015 at 06:23:19PM +0000, Rodrigo Vivi wrote:
> > I believe this function could be added along with the next patch that
> > is the first to use it...
> > Or it would be good to have a good commit message explaining why this
> > function is needed and what is be used for...
> 
> Yes, please don't split up patches so much that you end up adding dead code
> or dead structures - always try to have at least a minimal user for something.
> 
> If you want to split things up really tiny then go the other way round:
> First add the callers, then add the implementation. That way reviewers can
> understand the big scope first and then dig into details. But this one here really
> is small enough to just be squashed in.
> -Daniel
> 
[Zhang, Xiong Y] Thanks for teaching me how to handle this. I'll follow it in the next version.
thanks
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx